From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: SL Baur <steve@xemacs.org>, Andy Whitcroft <apw@shadowen.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: false positive in checkpatch.pl (complex macro values)
Date: Fri, 24 Aug 2007 12:47:43 -0400 [thread overview]
Message-ID: <20070824164741.GB1875@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <8bd0f97a0708240624v64b47b4l726a66f9766bc4a0@mail.gmail.com>
On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
...
> $ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
> #define AUREON_DEVICE_DESC "{Terratec,Aureon 5.1 Sky},"\
> "{Terratec,Aureon 7.1 Space},"\
> "{Terratec,Aureon 7.1 Universe}," \
> "{AudioTrak,Prodigy 7.1}," \
> "{AudioTrak,Prodigy 7.1 LT},"\
> "{AudioTrak,Prodigy 7.1 XT},"
This is a different thing. This is a long string, not a list of elements.
IMO, this one shouldn't have given a warning regardless of whether or not
the original case is valid.
Josef 'Jeff' Sipek.
--
If I have trouble installing Linux, something is wrong. Very wrong.
- Linus Torvalds
next prev parent reply other threads:[~2007-08-24 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 7:51 Mike Frysinger
2007-08-24 11:41 ` Andy Whitcroft
2007-08-24 12:43 ` SL Baur
2007-08-24 12:50 ` SL Baur
2007-08-24 13:24 ` Mike Frysinger
2007-08-24 16:47 ` Josef Sipek [this message]
2007-08-24 19:10 ` Mike Frysinger
2007-08-24 17:22 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824164741.GB1875@filer.fsl.cs.sunysb.edu \
--to=jsipek@fsl.cs.sunysb.edu \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=steve@xemacs.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®