From: "Scott Thompson" <postfail@hushmail.com>
To: <jirislaby@gmail.com>, <alan@lxorguk.ukuu.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
Date: Fri, 24 Aug 2007 15:31:21 -0400 [thread overview]
Message-ID: <20070824193127.7E067C3825@mailserver10.hushmail.com> (raw)
On Fri, 24 Aug 2007 15:15:30 -0400 Alan Cox
<alan@lxorguk.ukuu.org.uk> wrote:
>ase, 0x80);
>>
>> remove also the hwbase var.
>>
>> > + rebase = pci_iomap(pdev, 0, 0x80);
>> > t = readl(rebase + CNTRL_REG_OFFSET);
>
>Switch to ioread* if you are using the iomap interface. Its not a
>trivial
>conversion and its slower and bulkier - the original ioremap was
>much
>better
>
>NAK this change therefore
Jiri had requested this in relation to previous patch on unchecked
ioremap return codes, but if the original ioremap is better NAK is
fine
here and I won't resubmit w/ the hwbase var pulled out or the readl
-> ioread32 switchover.
---------------------------------------
Scott Thompson / postfail@hushmail.com
---------------------------------------
next reply other threads:[~2007-08-24 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 19:31 Scott Thompson [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-24 18:49 Scott Thompson
2007-08-24 18:59 ` Jiri Slaby
2007-08-24 19:15 ` Alan Cox
2007-08-24 20:03 ` Jiri Slaby
2007-08-24 20:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824193127.7E067C3825@mailserver10.hushmail.com \
--to=postfail@hushmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®