From: Oleg Nesterov <oleg@tv-sign.ru>
To: Cliff Wickman <cpw@sgi.com>, Paul Jackson <pj@sgi.com>,
Paul Menage <menage@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: cpuset: attach_task() vs sched_setaffinity() race?
Date: Sat, 25 Aug 2007 20:26:06 +0400 [thread overview]
Message-ID: <20070825162606.GA2630@tv-sign.ru> (raw)
After the brief look at kernel/cpuset.c, it seems that attach_task() should
guarantee that the task can't use CPUs outside of cpuset->cpus_allowed.
But this looks racy wrt sched_setaffinity() which does
cpus_allowed = cpuset_cpus_allowed(p);
// callback_mutex is free
set_cpus_allowed(p);
What if attach_task()->set_cpus_allowed() happens in between?
Another question: update_cpumask(cs) does nothing with the tasks attached to
that cpuset, why? It may take a while before the task actually migrates to the
new CPU.
Thanks,
Oleg.
next reply other threads:[~2007-08-25 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-25 16:26 Oleg Nesterov [this message]
2007-08-28 13:48 ` cpusets vs cpu-hotplug interaction is broken? Oleg Nesterov
2007-08-29 8:51 ` Gautham R Shenoy
2007-08-29 10:52 ` Oleg Nesterov
2007-08-29 12:51 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070825162606.GA2630@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®