From: Ingo Molnar <mingo@elte.hu>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: fix bogus hotplug cpu warning
Date: Tue, 28 Aug 2007 11:07:09 +0200 [thread overview]
Message-ID: <20070828090709.GA24578@elte.hu> (raw)
this commit:
commit d243769d3f83b318813a04a9592bb7cfedc6c280
Author: Hugh Dickins <hugh@veritas.com>
Date: Mon Aug 27 16:06:19 2007 +0100
fix bogus hotplug cpu warning
Fix bogus DEBUG_PREEMPT warning on x86_64, when cpu brought online
after bootup: current_is_keventd is right to note its use of
smp_processor_id is preempt-safe, but should use
raw_smp_processor_id to avoid the warning.
- int cpu = smp_processor_id(); /* preempt-safe: keventd is per-cpu */
+ int cpu = raw_smp_processor_id(); /* preempt-safe: keventd is per-cpu */
is incorrect. smp_processor_id() will _not_ warn about true per-cpu
tasks:
/*
* Kernel threads bound to a single CPU can safely use
* smp_processor_id():
*/
this_mask = cpumask_of_cpu(this_cpu);
if (cpus_equal(current->cpus_allowed, this_mask))
goto out;
so if this check triggered for the cpu-offline code it's because keventd
was _not_ per-cpu (perhaps because the cpu offline code broke its
affinity?). So your patch hides a real bug.
Ingo
next reply other threads:[~2007-08-28 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 9:07 Ingo Molnar [this message]
2007-08-28 9:30 ` Hugh Dickins
2007-08-28 10:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828090709.GA24578@elte.hu \
--to=mingo@elte.hu \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®