From: Sam Ravnborg <sam@ravnborg.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Roman Zippel <zippel@linux-m68k.org>,
linux-kernel@vger.kernel.org, kbuild-devel@lists.sourceforge.net
Subject: Re: CONFIG_HOTPLUG_CPU: kconfig bug?
Date: Wed, 29 Aug 2007 20:01:58 +0200 [thread overview]
Message-ID: <20070829180158.GA7849@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708272143150.29594@blonde.wat.veritas.com>
> > > I've noticed an oddity with CONFIG_HOTPLUG_CPU in 2.6.23-rc:
> > > make oldconfig seems to turn it on even when nothing wants it,
> > > increasing kernel size by about 10k; but if you then edit the
> > > line out of .config and make oldconfig again, it correctly
> > > offers the choice and lets it be turned off after all.
I have tried to track down what is happening here.
The culprint is:
config SUSPEND_SMP
bool
depends on SUSPEND_SMP_POSSIBLE && PM_SLEEP
select HOTPLUG_CPU
default y
It seems that due to the fact that SUSPEND_SMP is default y
then kconfig enforce the "select HOTPLUG_CPU".
And this happens despite the fact that PM_SLEEP is 'n'
(but SUSPEND_SMP_POSSIBLE is 'y').
It is somewhere in sym_calc_value() or one of the childs that
suddenly causes the change.
But I find it hard to follow this part of the logic in kconfig.
Roman - can you help here with what is going on?
Sam
next prev parent reply other threads:[~2007-08-29 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 14:54 Hugh Dickins
2007-08-27 17:26 ` Sam Ravnborg
2007-08-27 20:49 ` Hugh Dickins
2007-08-29 18:01 ` Sam Ravnborg [this message]
2007-08-30 3:06 ` Roman Zippel
2007-08-30 12:40 ` Hugh Dickins
2007-08-30 18:48 ` Rafael J. Wysocki
2007-08-30 21:06 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070829180158.GA7849@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=hugh@veritas.com \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®