mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@mvista.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	RT-Users <linux-rt-users@vger.kernel.org>
Subject: [PATCH 2.6.23-rc2-rt2] call IRQ-chip's end hook in thread_simple_irq()
Date: Thu, 30 Aug 2007 20:07:45 -0700	[thread overview]
Message-ID: <20070831030745.794000733@mvista.com> (raw)

When using the 'simple' handler as a chained handler, the end hook
should be called so the chained handler can properly ack/unmask
etc. after the threaded handler has completed.

In particular, the chained GPIO IRQ hander on OMAP uses the 'simple'
handler since the GPIO IRQs can be dynamically configured either as
edge or level.  When using threaded IRQs, the only way to know when
the handler is done and do the proper ack/unmask is via the end hook.

Signed-off-by: Kevin Hilman <khilman@mvista.com>

--- linux-2.6.21.orig/kernel/irq/manage.c
+++ linux-2.6.21/kernel/irq/manage.c
@@ -637,6 +637,8 @@ static void thread_simple_irq(irq_desc_t
 			note_interrupt(irq, desc, action_ret);
 	}
 	desc->status &= ~IRQ_INPROGRESS;
+	if (desc->chip->end)
+		desc->chip->end(irq);
 }
 
 /*
--

                 reply	other threads:[~2007-08-31  3:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070831030745.794000733@mvista.com \
    --to=khilman@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®