From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761749AbXHaUNS (ORCPT ); Fri, 31 Aug 2007 16:13:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754088AbXHaUNG (ORCPT ); Fri, 31 Aug 2007 16:13:06 -0400 Received: from xenotime.net ([66.160.160.81]:46843 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753619AbXHaUNF (ORCPT ); Fri, 31 Aug 2007 16:13:05 -0400 Date: Fri, 31 Aug 2007 13:13:01 -0700 From: Randy Dunlap To: Rob Landley Cc: Satyam Sharma , Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH] Documentation/00-INDEX notice ecryptfs.txt moved. Message-Id: <20070831131301.bd9e727d.rdunlap@xenotime.net> In-Reply-To: <200708311356.10826.rob@landley.net> References: <200708301446.18024.rob@landley.net> <200708302016.12133.rob@landley.net> <200708311356.10826.rob@landley.net> Organization: YPO4 X-Mailer: Sylpheed 2.4.2 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Aug 2007 13:56:10 -0500 Rob Landley wrote: > On Friday 31 August 2007 7:10:00 am Satyam Sharma wrote: > > Hi Rob, > > > > On Thu, 30 Aug 2007, Rob Landley wrote: > > > On Thursday 30 August 2007 2:04:37 pm Randy Dunlap wrote: > > > > Please use the expected (canonical) patch format. > > > > > > > > See Documentation/SubmittingPatches: > > > > 14) The canonical patch format > > > > > > from Rob Landley > > > Signed-off-by: Rob Landley > > > > > > ecryptfs.txt moved into filesystems, make 00-INDEX follow. > > > > That's still not quite right :-) What Randy meant is that the sign-off > > must come /after/ the patch description: > > Randy emailed me about it offline and I updated my wrapper script. > > I've always had a bit of a blind spot when it comes to filling out forms (I > suck at bureaucracy), so I made a script to do it, currently: > > #!/bin/bash > > echo "From: Rob Landley " > echo or: echo put_changelog_here > echo "Signed-off-by: Rob Landley " > echo "---" > echo > cat $1 | diffstat cat $1 | diffstat -p1 -w70 > echo > cat $1 > > I note that the example uses "From:" but the summary refers to it as > the "from" line with no capital letter or colon, and unix being case > sensitive I reproduced the quoted string verbatim. (See "I suck at > bureaucracy", above.) > > > [ All this is not too important, admittedly, but causes least amount of > > processing time to be wasted on the recipient's end, and also does not > > confuse scripts that may be used to extract patches (and git commit > > command-line arguments) from mails automatically. ] > > If it's going to be parsed by a script, it might as well be generated by a > script... yep. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***