From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sata_via: write errors on PATA drive connected to VT6421
Date: Sat, 1 Sep 2007 00:19:06 +0100 [thread overview]
Message-ID: <20070901001906.16c4db60@the-village.bc.nu> (raw)
In-Reply-To: <200709010055.22200.linux@rainbow-software.org>
On Sat, 1 Sep 2007 00:55:21 +0200
Ondrej Zary <linux@rainbow-software.org> wrote:
> Hello,
> I think that I've found and fixed the problem. There is a copy/paste bug in
> vt6421_set_dma_mode() function which causes wrong values to be written to
> PATA_UDMA_TIMING register.
>
>
> This patch fixes a copy/paste bug that breaks DMA modes on VT6421 PATA port.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
> --- linux-2.6.22.3-orig/drivers/ata/sata_via.c 2007-09-01 00:40:22.000000000 +0200
> +++ linux-2.6.22.3-router2/drivers/ata/sata_via.c 2007-09-01 00:10:40.000000000 +0200
> @@ -370,7 +370,7 @@
> {
> struct pci_dev *pdev = to_pci_dev(ap->host->dev);
> static const u8 udma_bits[] = { 0xEE, 0xE8, 0xE6, 0xE4, 0xE2, 0xE1, 0xE0, 0xE0 };
> - pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->pio_mode - XFER_UDMA_0]);
> + pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->dma_mode - XFER_UDMA_0]);
> }
>
> static const unsigned int svia_bar_sizes[] = {
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2007-08-31 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 20:42 Ondrej Zary
2007-08-21 12:27 ` Alan Cox
2007-08-21 17:09 ` Ondrej Zary
2007-08-31 22:55 ` Ondrej Zary
2007-08-31 23:19 ` Alan Cox [this message]
2007-09-01 10:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070901001906.16c4db60@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®