From: Oleg Nesterov <oleg@tv-sign.ru>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Michael Kerrisk <mtk-manpages@gmx.net>
Subject: Re: [RFC + PATCH] signalfd simplification
Date: Sun, 2 Sep 2007 17:02:34 +0400 [thread overview]
Message-ID: <20070902130234.GA183@tv-sign.ru> (raw)
In-Reply-To: <20070902121943.GA141@tv-sign.ru>
On 09/02, Oleg Nesterov wrote:
>
> Small problem: unless I missed something, signalfd_deliver() and sys_signalfd()
> should use wake_up_all(), not wake_up() which implies nr_exclusive == 1.
>
> It is possible that we have multiple threads waiting on ->signalfd_wqh with
> the the different ->sigmask. In this case, the first woken thread can ignore
> the signal, we should wake up all of them.
Oops, sorry for noise. I forgot about WQ_FLAG_EXCLUSIVE, we don't set it by
default.
Oleg.
next prev parent reply other threads:[~2007-09-02 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 23:27 Davide Libenzi
2007-09-02 12:19 ` Oleg Nesterov
2007-09-02 13:02 ` Oleg Nesterov [this message]
2007-09-02 14:39 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070902130234.GA183@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk-manpages@gmx.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®