mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: "Robert Richter" <robert.richter@amd.com>
Cc: "Andi Kleen" <ak@suse.de>,
	patches@x86-64.org, linux-kernel@vger.kernel.org,
	"Robert Richter" <robert.richter@amd.com>
Subject: Re: [patch 3/5] x86: Add PCI extended config space access for AMD Barcelona
Date: Mon, 3 Sep 2007 01:31:57 -0700	[thread overview]
Message-ID: <20070903013157.72c94891@laptopd505.fenrus.org> (raw)
In-Reply-To: <20070903081736.588599000@amd.com>

On Mon, 03 Sep 2007 10:17:39 +0200
"Robert Richter" <robert.richter@amd.com> wrote:

> This patch implements PCI extended configuration space access for
> AMD's Barcelona CPUs. It extends the method using CF8/CFC IO
> addresses. An x86 capability bit has been introduced that is set for
> CPUs supporting PCI extended config space accesses.
> 


No offence but this feels a bit wrong to me.

PCI is sort of more a chipset property than a cpu property (I realize
that this boundary is changing of course).

I'd like to ask you to at least rename some of the feature bits to
indicate that the extended config space is for the IO access method;
after all Linux already supports the MMIO method for accessing extended
config space since a really long time; not marking the feature bit to
indicate it's the IO method is going to be extremely confusing and
cause bugs I bet.

(we probably need a global function that drivers can use to find out of
extended config space is accessible; however that for sure isn't a CPU
capability bit. However the current naming etc sort of makes me fear
drivers will abuse this thing while thinking it's the right API)

  reply	other threads:[~2007-09-03  8:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-03  8:17 [patch 0/5] (resent) x86: PCI extended config space access on AMD Barcelona CPUs Robert Richter
2007-09-03  8:17 ` [patch 1/5] x86: Add AMD64 Barcelona PMU MSR definitions Robert Richter
2007-09-03  8:17 ` [patch 2/5] x86: Add AMD64 Barcelona NB cfg " Robert Richter
2007-09-03  8:17 ` [patch 3/5] x86: Add PCI extended config space access for AMD Barcelona Robert Richter
2007-09-03  8:31   ` Arjan van de Ven [this message]
2007-09-03  9:17     ` [patches] " Andreas Herrmann
2007-09-03 11:33       ` Arjan van de Ven
2007-09-03 15:47         ` Andreas Herrmann
2007-09-05  5:58           ` H. Peter Anvin
2007-09-05  8:44             ` Robert Richter
2007-09-05 10:12               ` H. Peter Anvin
2007-09-05 10:35                 ` Robert Richter
2007-09-05 11:05                 ` Arne Georg Gleditsch
2007-09-05 16:13                   ` Andreas Herrmann
2007-09-05 22:42                     ` Yinghai Lu
2007-09-06  8:31                       ` Arne Georg Gleditsch
2007-09-06  9:48                         ` H. Peter Anvin
2007-09-06 17:41                           ` Jesse Barnes
2007-09-06 17:50                             ` Yinghai Lu
2007-09-06 17:48                               ` Jesse Barnes
2007-09-06 17:48                           ` Yinghai Lu
2007-09-05 15:00             ` Andreas Herrmann
2007-09-06 10:14               ` Arjan van de Ven
2007-09-03  8:17 ` [patch 4/5] x86: Add PCI IDs for AMD Barcelona PCI devices Robert Richter
2007-09-03  8:17 ` [patch 5/5] x86: Set PCI config space size to extended for AMD Barcelona Robert Richter
2007-09-03 16:48   ` dean gaudet
2007-09-03 18:18     ` Robert Richter
2007-09-03 19:01     ` Martin Mares
     [not found] <20070830174311.221133000@amd.com>
     [not found] ` <20070830174311.536394000@amd.com>
2007-09-01 10:11   ` [patch 3/5] x86: Add PCI extended config space access " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070903013157.72c94891@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®