mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Jeff Norden <jeff@math.tntech.edu>,
	alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
Date: Thu, 6 Sep 2007 01:39:29 +0100	[thread overview]
Message-ID: <20070906013929.1621849d@the-village.bc.nu> (raw)
In-Reply-To: <18141.42848.537873.349518@alkaid.it.uu.se>

/from the media. */
>  > +	if (qc->nbytes < 2048)
>  > +		return -EOPNOTSUPP;
>  > +
>  >  	/* No ATAPI DMA in smart mode */
>  >  	if (itdev->smart)
>  >  		return -EOPNOTSUPP;
>  > 
> 
> This looks like a gross hack. Aren't you supposed to inspect
> the command instead and whitelist the ones you know are OK,
> like pata_pdc2027x.c and sata_promise.c do?

It does seem to be about transfer size in the IT821x case not commands.
It may be to do with how we issue ATAPI command transfer sizes from high
up (patch went to Jeff) but for now this is definitely the right approach

Reviewed-by: Alan Cox <alan@redhat.com>

  reply	other threads:[~2007-09-06  0:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-04 16:07 Jeff Norden
2007-09-04 18:43 ` Mikael Pettersson
2007-09-06  0:39   ` Alan Cox [this message]
2007-09-17  5:00     ` Tejun Heo
2007-09-17 10:00       ` Jeff Garzik
2007-09-17 11:46         ` Tejun Heo
2007-09-18  9:14           ` Alan Cox
2007-09-18  9:07       ` Alan Cox
2007-09-11  1:53 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070906013929.1621849d@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=jeff@math.tntech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®