From: Randy Dunlap <randy.dunlap@oracle.com>
To: Anders Blomdell <anders.blomdell@control.lth.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Stray nulls when reading from AF_UNIX sockets
Date: Thu, 6 Sep 2007 09:09:50 -0700 [thread overview]
Message-ID: <20070906090950.21d3d637.randy.dunlap@oracle.com> (raw)
In-Reply-To: <46E02137.8030600@control.lth.se>
On Thu, 06 Sep 2007 17:48:07 +0200 Anders Blomdell wrote:
> Hi,
>
> With recent kernels (2.6.22.x), we are experiencing that random null characters
> are read by our mySQL server (i.e. the number of bytes read by the server is
> larger than the number of bytes written). I'm currently investigating the
> problem (that occurs every 1-35 hours on a loaded system). A current suspect is
> the following code in net/unix/af_unix.c:
>
> static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock,
> struct msghdr *msg, size_t size,
> int flags)
> {
> ...
> return copied ? : err;
> }
>
> Shouldn't this read:
>
> return copied ? copied : err;
>
> Or am I missing something?
>
> Please CC me personally.
It's (?:) a gcc extension. See
http://gcc.gnu.org/onlinedocs/gcc-4.2.1/gcc/Conditionals.html#Conditionals
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-09-06 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 15:48 Anders Blomdell
2007-09-06 16:09 ` Randy Dunlap [this message]
2007-09-06 19:23 ` David Miller
2007-09-07 11:52 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906090950.21d3d637.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=anders.blomdell@control.lth.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome