From: Pavel Machek <pavel@ucw.cz>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fujtisu application panel driver
Date: Fri, 7 Sep 2007 12:02:20 +0000 [thread overview]
Message-ID: <20070907120220.GB3901@ucw.cz> (raw)
In-Reply-To: <20070903095847.72245af4@oldman>
Hi!
> > Thank you very much for updating the patch. I have a couple of requests though:
> >
> > 1. LEDs shoud use the generic led subsystem instead of input layer. I
> > do not have plans of adding any more LED_XXX constants and I think
> > that adding any LEDs not directly relating to keyboard state was a
> > mistake.
>
> No, way to much work for one stinking LED.
'Lets do it wrong way because right way is too much work'?
Come on... doing let driver is 30 minutes and 100-or-so lines of code.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-09-07 12:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 18:17 Stephen Hemminger
2007-07-02 19:16 ` Dmitry Torokhov
2007-09-03 8:58 ` Stephen Hemminger
2007-09-07 12:02 ` Pavel Machek [this message]
2007-09-12 11:38 ` [PATCH] Fujitsu application panel driver (rev3) Stephen Hemminger
2007-09-14 5:30 ` Dmitry Torokhov
2007-09-16 19:55 ` Stephen Hemminger
2007-09-16 20:22 ` Dmitry Torokhov
2007-10-23 19:55 ` [PATCH] Fujitsu application panel driver Stephen Hemminger
2007-10-24 23:03 ` Andrew Morton
2007-10-25 20:19 ` [PATCH] apanel: space savings Stephen Hemminger
2007-10-28 5:30 ` [PATCH] Fujitsu application panel driver Dmitry Torokhov
2007-11-18 22:36 ` Robert Gerlach
2007-11-19 4:43 ` Stephen Hemminger
2007-11-19 12:50 ` Robert Gerlach
2007-11-19 17:26 ` Stephen Hemminger
2007-11-19 20:37 ` Robert Gerlach
2007-11-19 23:19 ` Stephen Hemminger
2007-12-19 9:04 ` Robert Gerlach
2007-12-12 14:10 ` Dmitry Torokhov
2007-12-12 22:21 ` [PATCH] Fujitsu application panel led value Stephen Hemminger
2007-07-05 1:29 ` [PATCH] fujtisu application panel driver Jason Uhlenkott
2007-09-03 9:00 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907120220.GB3901@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®