From: David Miller <davem@davemloft.net>
To: dwalker@mvista.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: myri10ge: force select inet_lro
Date: Sat, 08 Sep 2007 01:22:14 -0700 (PDT) [thread overview]
Message-ID: <20070908.012214.41650322.davem@davemloft.net> (raw)
In-Reply-To: <20070907202625.702755508@mvista.com>
From: Daniel Walker <dwalker@mvista.com>
Date: Fri, 07 Sep 2007 13:26:25 -0700
> This driver uses the inet_lro facilities , but it doesn't force it
> to be enabled .. Someone would have to know to enable inet_lro if
> they select the driver ..
>
> Instead, just force INET_LRO if this driver is selected..
>
> Signed-off-by: Daniel Walker <dwalker@mvista.com>
I put this exact fix into the net-2.6.24 tree several days ago
already, it's not nice that you didn't even bother checking.
When I saw the response to the help@ address, I could almost predict
that the myri10ge developers would not even check if net-2.6.24 had
the issue cured already.
Therefore, your patch doesn't even apply to the tree where it is
relevant. That sucks.
next prev parent reply other threads:[~2007-09-08 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 20:26 Daniel Walker
2007-09-08 8:22 ` David Miller [this message]
2007-09-08 16:03 ` Daniel Walker
2007-09-08 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070908.012214.41650322.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®