From: Arjan van de Ven <arjan@infradead.org>
To: "Adrian McMenamin" <lkmladrian@gmail.com>
Cc: "Dmitry Torokhov" <dtor@insightbb.com>,
"Paul Mundt" <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Maple bus support for the Sega Dreamcast - keyboard support
Date: Sun, 9 Sep 2007 19:30:40 +0100 [thread overview]
Message-ID: <20070909193040.2fb9d010@laptopd505.fenrus.org> (raw)
In-Reply-To: <8b67d60709091001l3cd6adf6m2dab8e815f47435d@mail.gmail.com>
On Sun, 9 Sep 2007 18:01:26 +0100
"Adrian McMenamin" <lkmladrian@gmail.com> wrote:
> This patch adds support for the SEGA Dreamcast keyboard.
>
> Following suggestions from the inout maintainer it has been somewhat
> rewritten since the previous posting
> (http://lkml.org/lkml/2007/9/4/168).
Hi,
this driver in general is quite clean as well; I have only one
suggestion for improvement. Right now you use a semaphore for locking,
while all you really use it for is mutex semantics, I think it would be
a good idea to convert the driver to use the actual mutex primitive;
this will buy you a lot of extra automatic checking for bugs...
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2007-09-09 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-09 17:01 Adrian McMenamin
2007-09-09 18:30 ` Arjan van de Ven [this message]
2007-09-09 20:35 ` Adrian McMenamin
2007-09-09 20:44 ` Arjan van de Ven
2007-09-09 20:57 ` Adrian McMenamin
2007-09-09 21:03 ` Arjan van de Ven
2007-09-10 3:50 ` Dmitry Torokhov
2007-09-10 14:28 ` Adrian McMenamin
2007-09-10 15:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070909193040.2fb9d010@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=dtor@insightbb.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome