From: Ingo Oeser <ioe-lkml@rameria.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Bob Gilligan <gilligan@vyatta.com>,
linux-kernel@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
Date: Mon, 10 Sep 2007 21:46:46 +0200 [thread overview]
Message-ID: <200709102146.47655.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20070910075829.GA25851@gondor.apana.org.au>
Hi Herbert,
On Monday 10 September 2007, Herbert Xu wrote:
> On Sat, Sep 08, 2007 at 12:14:23PM +0800, Herbert Xu wrote:
> >
> > [CRYPTO] blkcipher: Fix handling of kmalloc page straddling
>
> As Bob correctly noted, I had the boolean test inverted.
> Here is the correction:
>
> [CRYPTO] blkcipher: Fix inverted test in blkcipher_get_spot
>
> The previous patch had the conditional inverted. This patch fixes it
> so that we return the original position if it does not straddle a page.
What about using max() for this to make your intention obvious?
static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len)
{
u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK);
return max(start, end_page);
}
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2007-09-10 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 0:09 Bob Gilligan
2007-09-08 4:14 ` Herbert Xu
2007-09-10 7:58 ` Herbert Xu
2007-09-10 19:46 ` Ingo Oeser [this message]
2007-09-11 8:40 ` Herbert Xu
2007-09-11 19:53 ` [PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention Ingo Oeser
2007-09-19 11:16 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709102146.47655.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=gilligan@vyatta.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®