From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH -mm] fs: define file_fsync() even for CONFIG_BLOCK=n
Date: Wed, 12 Sep 2007 11:06:10 +0900 [thread overview]
Message-ID: <20070912020610.GA26827@linux-sh.org> (raw)
There's nothing that is problematic for file_fsync() with CONFIG_BLOCK=n,
and it's built in unconditionally anyways, so move the prototype out to
reflect that. Without this, the unionfs build bails out.
CC fs/unionfs/file.o
fs/unionfs/file.c:148: error: 'file_fsync' undeclared here (not in a function)
make[2]: *** [fs/unionfs/file.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [fs/unionfs] Error 2
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
include/linux/buffer_head.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1.orig/include/linux/buffer_head.h 2007-09-11 15:15:56.000000000 +0900
+++ linux-2.6.23-rc4-mm1/include/linux/buffer_head.h 2007-09-12 10:18:57.000000000 +0900
@@ -14,6 +14,8 @@
#include <linux/wait.h>
#include <asm/atomic.h>
+int file_fsync(struct file *, struct dentry *, int);
+
#ifdef CONFIG_BLOCK
enum bh_state_bits {
@@ -225,7 +227,6 @@
sector_t generic_block_bmap(struct address_space *, sector_t, get_block_t *);
int generic_commit_write(struct file *, struct page *, unsigned, unsigned);
int block_truncate_page(struct address_space *, loff_t, get_block_t *);
-int file_fsync(struct file *, struct dentry *, int);
int nobh_prepare_write(struct page*, unsigned, unsigned, get_block_t*);
int nobh_commit_write(struct file *, struct page *, unsigned, unsigned);
int nobh_truncate_page(struct address_space *, loff_t);
next reply other threads:[~2007-09-12 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 2:06 Paul Mundt [this message]
2007-09-12 9:30 ` Christoph Hellwig
2007-09-12 23:27 ` Josef Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912020610.GA26827@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®