From: Steve Wise <swise@opengridcomputing.com>
To: rdreier@cisco.com, sean.hefty@intel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
general@lists.openfabrics.org
Subject: [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.
Date: Wed, 12 Sep 2007 05:00:25 -0500 [thread overview]
Message-ID: <20070912100025.3190.89259.stgit@dell3.ogc.int> (raw)
RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.
Calling arp_send() to initiate neighbour discovery (ND) doesn't do the
full ND protocol. Namely, it doesn't handle retransmitting the arp
request if it is dropped. The function neigh_event_send() does all this.
Without doing full ND, rdma address resolution fails in the presence of
dropped arp bcast packets.
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
drivers/infiniband/core/addr.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index c5c33d3..5381c80 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -161,8 +161,7 @@ static void addr_send_arp(struct sockadd
if (ip_route_output_key(&rt, &fl))
return;
- arp_send(ARPOP_REQUEST, ETH_P_ARP, rt->rt_gateway, rt->idev->dev,
- rt->rt_src, NULL, rt->idev->dev->dev_addr, NULL);
+ neigh_event_send(rt->u.dst.neighbour, NULL);
ip_rt_put(rt);
}
next reply other threads:[~2007-09-12 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 10:00 Steve Wise [this message]
2007-09-12 18:13 ` Sean Hefty
2007-09-18 17:23 ` Steve Wise
2007-09-20 16:31 ` Roland Dreier
2007-09-16 7:34 ` [ofa-general] " Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912100025.3190.89259.stgit@dell3.ogc.int \
--to=swise@opengridcomputing.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®