From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Greg KH <gregkh@suse.de>
Cc: Matthew Wilcox <matthew@wil.cx>,
Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH]PCI:disable resource decode in PCI BAR detection
Date: Thu, 13 Sep 2007 15:16:37 +0400 [thread overview]
Message-ID: <20070913151637.A1679@jurassic.park.msu.ru> (raw)
In-Reply-To: <20070913095313.GA745@suse.de>; from gregkh@suse.de on Thu, Sep 13, 2007 at 02:53:13AM -0700
On Thu, Sep 13, 2007 at 02:53:13AM -0700, Greg KH wrote:
> On Thu, Sep 13, 2007 at 01:55:36AM -0600, Matthew Wilcox wrote:
> > Unfortunately if this patch does cause any machine to break, these will
> > be machines that worked fine up until this point, so that would be a
> > regression, which is worse. Life sucks.
>
> If, after a while, you think the change should go into the -stable tree,
> I have no objection.
I think it shouldn't - this change will almost certainly cause a regression.
There is a lot of system devices besides the host bridges that shouldn't be
disabled during BAR probe, like interrupt controllers, power management
controllers and so on.
We need a more sophisticated fix - I'm thinking of introducing "probe" field
in struct pci_dev which can be set by "early" quirk routines.
Ivan.
next prev parent reply other threads:[~2007-09-13 11:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 6:21 Shaohua Li
2007-09-13 7:31 ` Matthew Wilcox
2007-09-13 7:24 ` Shaohua Li
2007-09-13 7:55 ` Matthew Wilcox
2007-09-13 9:53 ` Greg KH
2007-09-13 11:16 ` Ivan Kokshaysky [this message]
2007-09-13 12:00 ` Greg KH
2007-09-16 20:01 ` Benjamin Herrenschmidt
2007-09-17 10:22 ` Ivan Kokshaysky
2007-09-17 20:30 ` Benjamin Herrenschmidt
2007-09-18 9:54 ` Ivan Kokshaysky
[not found] <fa.ggBqx6W3i6hfs6jdfg64oXKSxW8@ifi.uio.no>
[not found] ` <fa.o5cJ0O7pLVWRzUiVPDEZL6nKqA8@ifi.uio.no>
[not found] ` <fa.tyYt4GOpTOmJTUbzsxpiCAObJPQ@ifi.uio.no>
[not found] ` <fa.13eJumylqINOxOaoEj9cthw0d0M@ifi.uio.no>
[not found] ` <fa.tAIuIM02CoL+ixB11n9Fmcqyz9M@ifi.uio.no>
[not found] ` <fa.pxFYhTaUz2NVN7Vux7b5xVRrKTw@ifi.uio.no>
2007-09-14 3:32 ` Robert Hancock
2007-09-14 11:14 ` Ivan Kokshaysky
2007-09-14 11:33 ` Ivan Kokshaysky
2007-09-14 14:30 ` Robert Hancock
2007-09-14 15:29 ` Ivan Kokshaysky
2007-09-14 23:53 ` Robert Hancock
2007-09-15 5:55 ` Yinghai Lu
2007-09-16 11:13 ` Ivan Kokshaysky
2007-09-16 17:34 ` Robert Hancock
2007-09-17 9:20 ` Ivan Kokshaysky
2007-09-16 19:52 ` Matthew Wilcox
2007-09-17 9:31 ` Ivan Kokshaysky
2007-09-17 14:30 ` Robert Hancock
2007-09-17 1:21 ` Shaohua Li
2007-09-18 9:53 ` Ivan Kokshaysky
2007-09-19 21:34 ` Jesse Barnes
2007-09-16 20:06 ` Benjamin Herrenschmidt
2007-09-16 23:37 ` Robert Hancock
2007-09-17 0:21 ` Benjamin Herrenschmidt
[not found] ` <fa.0Edi0qLTdvqVnuoDAebaTVz1jEM@ifi.uio.no>
[not found] ` <fa.sq+NimBnzGB2syLmvcIGOvDkixI@ifi.uio.no>
[not found] ` <fa.G9DPndNUxuPi5LrUTOL4uPFshnc@ifi.uio.no>
2007-09-26 23:01 ` Robert Hancock
2007-09-27 0:40 ` Benjamin Herrenschmidt
2007-09-27 2:14 ` Matthew Wilcox
[not found] <fa.+WRenB38novq157RnGPLoU4q2XI@ifi.uio.no>
[not found] ` <fa.mM7Va6Nlsaduo/AF4MkeurSBTbs@ifi.uio.no>
[not found] ` <fa.Ff0IMhMYWp7NYEdjO0AftHzVOh4@ifi.uio.no>
[not found] ` <fa.d9zBdhHd9gKcJbtwrYguusbECo4@ifi.uio.no>
[not found] ` <fa.TLO57rS9iV7zhomQxJbV9gjbxx8@ifi.uio.no>
[not found] ` <fa.lPg6OSzX+f6jdXK1ZF0rlIhZok4@ifi.uio.no>
2007-09-15 20:24 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913151637.A1679@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®