From: Borislav Petkov <bbpetkov@yahoo.de>
To: Satyam Sharma <satyam@infradead.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Muli Ben-Yehuda <muli@il.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1
Date: Tue, 18 Sep 2007 08:34:43 +0200 [thread overview]
Message-ID: <20070918063443.GB14903@gollum.tnic> (raw)
In-Reply-To: <alpine.LFD.0.999.0709181145060.14771@enigma.security.iitk.ac.in>
On Tue, Sep 18, 2007 at 11:46:40AM +0530, Satyam Sharma wrote:
> Hi Borislav,
>
>
> On Tue, 18 Sep 2007, Borislav Petkov wrote:
>
> > On Mon, Sep 17, 2007 at 11:01:21PM -0700, Jeremy Fitzhardinge wrote:
> > > Muli Ben-Yehuda wrote:
> > > >> +#define DMA_64BIT_MASK DMA_BIT_MASK(64)
> > > >>
> > > >
> > > > This one does not do what you mean. You need an explicit mask or a
> > > > ~0ULL here.
> > >
> > > Yeah, I was just about to comment on it. Its possible the compiler
> > > might decide to shift by x%64 = 0.
> > >
> > > J
> > ups, i knew that this might be a corner/boundary case. Thanks, updated patches
> > follow...
>
> Please fold all three patches into a single patch in the updated series,
> otherwise git bisecters falling in between these patches will see the
> "redefinition ... previous definition was here" warnings of gcc ...
Will do later today, thanks.
--
Regards/Gruß,
Boris.
prev parent reply other threads:[~2007-09-18 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 4:29 Borislav Petkov
2007-09-18 5:58 ` Muli Ben-Yehuda
2007-09-18 6:01 ` Jeremy Fitzhardinge
2007-09-18 6:08 ` Borislav Petkov
2007-09-18 6:16 ` Satyam Sharma
2007-09-18 6:34 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918063443.GB14903@gollum.tnic \
--to=bbpetkov@yahoo.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®