From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Combine instrumentation menus in kernel/Kconfig.instrumentation
Date: Tue, 18 Sep 2007 11:37:28 -0700 [thread overview]
Message-ID: <20070918113728.a0f38a3c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070917184552.GA5356@Krystal>
On Mon, 17 Sep 2007 14:45:52 -0400 Mathieu Desnoyers wrote:
> Combine instrumentation menus in kernel/Kconfig.instrumentation
Thanks, looks very good.
> Quoting Randy:
>
> "It seems sad that this patch sources Kconfig.marker, a 7-line file,
> 20-something times. Yes, you (we) don't want to put those 7 lines
> into 20-something different files, so sourcing is the right thing.
>
> However, what you did for avr32 seems more on the right track to me:
> make _one_ Instrumentation support menu that includes PROFILING,
> OPROFILE, KPROBES, and MARKERS and then use (source) that in all
> of the arches."
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> CC: Randy Dunlap <randy.dunlap@oracle.com>
Reviewed-by: Randy Dunlap <randy.dunlap@oracle.com>
or
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/alpha/Kconfig | 2 -
> arch/alpha/oprofile/Kconfig | 23 ----------------------
> arch/arm/Kconfig | 2 -
> arch/arm/oprofile/Kconfig | 42 -----------------------------------------
> arch/blackfin/Kconfig | 2 -
> arch/blackfin/oprofile/Kconfig | 29 ----------------------------
> arch/cris/Kconfig | 2 +
> arch/frv/Kconfig | 2 +
> arch/h8300/Kconfig | 2 +
> arch/i386/Kconfig | 25 ------------------------
> arch/i386/oprofile/Kconfig | 17 ----------------
> arch/ia64/Kconfig | 15 --------------
> arch/ia64/oprofile/Kconfig | 20 -------------------
> arch/m32r/Kconfig | 2 -
> arch/m32r/oprofile/Kconfig | 23 ----------------------
> arch/m68k/Kconfig | 2 +
> arch/m68knommu/Kconfig | 2 +
> arch/mips/Kconfig | 2 -
> arch/mips/oprofile/Kconfig | 23 ----------------------
> arch/parisc/Kconfig | 2 -
> arch/parisc/oprofile/Kconfig | 23 ----------------------
> arch/powerpc/Kconfig | 15 --------------
> arch/powerpc/oprofile/Kconfig | 24 -----------------------
> arch/ppc/Kconfig | 2 -
> arch/s390/Kconfig | 16 ---------------
> arch/s390/oprofile/Kconfig | 22 ---------------------
> arch/sh/Kconfig | 2 -
> arch/sh/oprofile/Kconfig | 23 ----------------------
> arch/sh64/Kconfig | 2 -
> arch/sh64/oprofile/Kconfig | 23 ----------------------
> arch/sparc/Kconfig | 6 -----
> arch/sparc/oprofile/Kconfig | 17 ----------------
> arch/sparc64/Kconfig | 15 --------------
> arch/sparc64/oprofile/Kconfig | 17 ----------------
> arch/um/Kconfig | 2 +
> arch/v850/Kconfig | 2 +
> arch/x86_64/Kconfig | 15 --------------
> arch/x86_64/oprofile/Kconfig | 17 ----------------
> arch/xtensa/Kconfig | 2 +
> kernel/Kconfig.instrumentation | 40 +++++++++++++++++++++++++++++++++++++++
> 40 files changed, 72 insertions(+), 452 deletions(-)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-09-18 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 18:45 Mathieu Desnoyers
2007-09-18 18:37 ` Randy Dunlap [this message]
2007-09-18 21:12 Mathieu Desnoyers
2007-09-18 21:45 ` Valdis.Kletnieks
2007-09-19 1:06 ` Mathieu Desnoyers
2007-09-19 5:57 ` Valdis.Kletnieks
2007-09-19 11:20 ` Mathieu Desnoyers
2007-09-19 11:33 ` Robert P. J. Day
2007-09-19 11:45 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918113728.a0f38a3c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®