mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tes@sgi.com (Tim Shimmin)
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com, akpm@linux-foundation.org
Subject: [GIT PULL] XFS update for 2.6.23
Date: Thu, 20 Sep 2007 20:12:10 +1000	[thread overview]
Message-ID: <20070920101210.6631358C4C09@chook.melbourne.sgi.com> (raw)

Hi Linus,

A couple of small fixes.
One for harmless sparse warnings and one which can prevent
crashes on 32 bit boxes using filestreams.

Please pull from the for-linus branch:
    git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus

This will update the following files:

 fs/xfs/xfs_filestream.c  |    7 ++++---
 fs/xfs/xfs_log_recover.c |    4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

through these commits:

commit 1bc5858d0d40e07697b5eda47ed8628b8a934235
Author: Christoph Hellwig <hch@infradead.org>
Date:   Wed Sep 19 15:27:30 2007 +1000

    [XFS] fix valid but harmless sparse warning
    
    The new xlog_recover_do_reg_buffer checks call be16_to_cpu on di_gen which
    is a 32bit value so sparse rightly complains. Fortunately the warning is
    harmless because we don't care for the value, but only whether it's
    non-NULL. Due to that fact we can simply kill the endian swaps on this and
    the previous di_mode check entirely.
    
    SGI-PV: 969656
    SGI-Modid: xfs-linux-melb:xfs-kern:29709a
    
    Signed-off-by: Christoph Hellwig <hch@infradead.org>
    Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

commit bcc7b445eff295664a3a3ab14e742b3c9d88e6e3
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Thu Aug 30 17:21:38 2007 +1000

    [XFS] fix filestreams on 32-bit boxes
    
    xfs_filestream_mount() sets up an mru cache with:
      err = xfs_mru_cache_create(&mp->m_filestream, lifetime, grp_count,
      (xfs_mru_cache_free_func_t)xfs_fstrm_free_func);
    but that cast is causing problems...
      typedef void (*xfs_mru_cache_free_func_t)(unsigned long, void*);
    but:
      void xfs_fstrm_free_func( xfs_ino_t ino, fstrm_item_t *item)
    so on a 32-bit box, it's casting (32, 32) args into (64, 32) and I assume
    it's getting garbage for *item, which subsequently causes an explosion.
    With this change the filestreams xfsqa tests don't oops on my 32-bit box.
    
    SGI-PV: 967795
    SGI-Modid: xfs-linux-melb:xfs-kern:29510a
    
    Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
    Signed-off-by: David Chinner <dgc@sgi.com>
    Signed-off-by: Tim Shimmin <tes@sgi.com>

--Tim

             reply	other threads:[~2007-09-20 10:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-20 10:12 Tim Shimmin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-18 11:24 Tim Shimmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070920101210.6631358C4C09@chook.melbourne.sgi.com \
    --to=tes@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®