From: Sam Ravnborg <sam@ravnborg.org>
To: "Gregory 'GaLi' Cavelier" <gali@cleia.org>
Cc: kkeil@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ISDN: Change pci_find_device() calls to pci_get_device()
Date: Fri, 21 Sep 2007 12:01:33 +0200 [thread overview]
Message-ID: <20070921100133.GA18631@uranus.ravnborg.org> (raw)
In-Reply-To: <20070921105508.d1a6a369.gali@cleia.org>
Hi Gregory.
On Fri, Sep 21, 2007 at 10:55:08AM +0200, Gregory 'GaLi' Cavelier wrote:
>
> The following patch removes the obsolete pci_find_device() calls and replaces them with pci_get_device() for all ISDN drivers.
>
> Compilation is fine but I haven't tested it since I don't own a ISDN card. Should be fine since the return value and parameters of pci_find_device() and pci_get_device() are the same.
>
> The is my first patch so be nice to me :)
Jeff Garzik has been doing a lot of work lately on the ISDN subsystem.
So please check his work to avoid doing the same work twice.
Of benefit for everyone would be a throughfull review of the changes
Jeff made. It is a nice learning expericen if not anything else.
You can find the ISDN change in one of the branches in Jeff's
public treee's at git.kernel.org.
Try also to seach the lkml archives for his work.
All that said I have not chacked if he addressed this specific cleanup.
Sam
prev parent reply other threads:[~2007-09-21 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 8:55 Gregory 'GaLi' Cavelier
2007-09-21 9:22 ` Surya Prabhakar N
2007-09-21 9:44 ` Andre Haupt
2007-09-21 9:56 ` Gregory 'GaLi' Cavelier
2007-09-21 10:01 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921100133.GA18631@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gali@cleia.org \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®