From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Guennadi Liakhovetski <gl@dsa-ac.de>
Cc: Mike Rapoport <mike@compulab.co.il>,
ARM Linux <linux-arm-kernel@lists.arm.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/03] CM-x270: ITE 8152 PCI bridge support
Date: Fri, 21 Sep 2007 14:01:20 +0100 [thread overview]
Message-ID: <20070921130119.GB20538@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.63.0709211240570.9343@pcgl.dsa-ac.de>
On Fri, Sep 21, 2007 at 12:42:55PM +0200, Guennadi Liakhovetski wrote:
> On Thu, 20 Sep 2007, Mike Rapoport wrote:
>
> > This patch provides driver for ITE 8152 PCI bridge.
> >
> > Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> >
> > arch/arm/common/Makefile | 1 +
> > arch/arm/common/it8152.c | 387 +++++++++++++++++++++++++++++++++++++
>
> Shouldn't it go to drivers/pci and define a platform driver? it8152 is not
> an ARM specific controller.
drivers/pci is currently only used for the PCI bus infrastructure. The
setup of host bridges is very platform dependent.
Also note that you should *avoid* DMA bounce wherever possible.
The code is broken as designed. Ensure that the DMA mask is set
appropriately, and then moan elsewhere if things don't work.
next prev parent reply other threads:[~2007-09-21 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 16:04 Mike Rapoport
2007-09-21 10:42 ` Guennadi Liakhovetski
2007-09-21 13:01 ` Russell King - ARM Linux [this message]
2007-09-21 20:11 ` Mike Rapoport
2007-09-21 20:11 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921130119.GB20538@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=gl@dsa-ac.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome