mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Olof Johansson <olof@lixom.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
	hch@lst.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t
Date: Fri, 21 Sep 2007 23:39:36 +0100	[thread overview]
Message-ID: <20070921233936.2aeb2504@the-village.bc.nu> (raw)
In-Reply-To: <20070921221516.GA7926@lixom.net>

On Fri, 21 Sep 2007 17:15:16 -0500
Olof Johansson <olof@lixom.net> wrote:

> Convert the io_req_t members to kio_addr_t, to allow use on machines with
> more than 16 bits worth of IO ports (i.e. secondary busses on ppc64, etc).

What about the formatting and field widths ?

ulong would probably be a lot saner than kio_addr_t and yet more type
obfuscation.

Otherwise looks sensible to me

  reply	other threads:[~2007-09-21 22:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05 14:27 [PATCH] " Olof Johansson
2007-09-14 10:48 ` Andrew Morton
2007-09-14 16:52   ` Olof Johansson
2007-09-21 22:15   ` [PATCH v2] " Olof Johansson
2007-09-21 22:39     ` Alan Cox [this message]
2007-09-22  6:25       ` Matthew Wilcox
2007-09-22  9:13         ` Christoph Hellwig
2007-10-19 20:17           ` [PATCH v3] pcmcia: Convert io_req_t to use unsigned int Olof Johansson
2007-10-28 13:44             ` Dominik Brodowski
2007-10-28 20:10               ` [PATCH] pcmcia: Remove replace kio_addr_t with unsigned int everywhere Olof Johansson
2007-10-28 20:18                 ` [PATCH v2] " Olof Johansson
2007-10-28 23:50                   ` Stephen Rothwell
2007-10-29  0:16                     ` Olof Johansson
2007-11-04  9:11                 ` Komuro
2007-09-22 15:11         ` [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070921233936.2aeb2504@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®