From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: roel <12o3l@tiscali.nl>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, axboe@kernel.dk,
akpm@linux-foundation.org
Subject: Re: [patch 1/2] Enable link power management for ata drivers
Date: Mon, 24 Sep 2007 16:41:18 -0700 [thread overview]
Message-ID: <20070924164118.803cfb22.kristen.c.accardi@intel.com> (raw)
In-Reply-To: <46F84460.5090703@tiscali.nl>
On Tue, 25 Sep 2007 01:12:32 +0200
roel <12o3l@tiscali.nl> wrote:
> > #define ata_id_cdb_intr(id) (((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id) \
> > + ( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> > + ((id)[76] & (1 << 9)) )
> ^
> |
> are you sure this
> should be 76?
Yes.
>
> we can also change the first statement a bit:
> (!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \
>
>
> > +#define ata_id_has_dipm(id) \
> > + ( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
>
> and:
> (!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \
I feel this is equivalent functionality and not as readable.
next prev parent reply other threads:[~2007-09-24 23:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070924215140.966161778@intel.com>
2007-09-24 22:13 ` Kristen Carlson Accardi
2007-09-24 23:12 ` roel
2007-09-24 23:28 ` Davide Libenzi
2007-09-25 0:00 ` roel
2007-09-24 23:41 ` Kristen Carlson Accardi [this message]
2007-09-24 23:59 ` Jeff Garzik
2007-09-25 9:50 ` Alan Cox
2007-09-26 2:45 ` Jeff Garzik
2007-10-25 5:21 ` Jeff Garzik
2007-09-24 22:14 ` [patch 2/2] Enable Aggressive Link Power management for AHCI controllers Kristen Carlson Accardi
2007-10-25 5:34 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924164118.803cfb22.kristen.c.accardi@intel.com \
--to=kristen.c.accardi@intel.com \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®