From: David Miller <davem@davemloft.net>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: kamalesh@linux.vnet.ibm.com
Subject: Re: + git-net-fix-pasemi_mac.patch added to -mm tree
Date: Tue, 25 Sep 2007 23:02:51 -0700 (PDT) [thread overview]
Message-ID: <20070925.230251.120461813.davem@davemloft.net> (raw)
In-Reply-To: <200709242233.l8OMXsL5021125@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Mon, 24 Sep 2007 15:33:54 -0700
> Subject: git-net: fix pasemi_mac
> From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>
> drivers/net/pasemi_mac.c: In function ^[$,1rx^[(Bpasemi_mac_probe^[$,1ry^[(B:
> drivers/net/pasemi_mac.c:1153: error: conflicting types for ^[$,1rx^[(Bmac^[$,1ry^[(B
> drivers/net/pasemi_mac.c:1151: error: previous declaration of ^[$,1rx^[(Bmac^[$,1ry^[(B was here
> drivers/net/pasemi_mac.c:1170: error: incompatible types in assignment
> drivers/net/pasemi_mac.c:1172: error: request for member ^[$,1rx^[(Bpdev^[$,1ry^[(B in
> something not a structure or union
>
> In the function
> static int __devinit
> pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> <snip>
> struct pasemi_mac *mac;
> int err;
> DECLARE_MAC_BUF(mac);
>
> introduction of mac as var [18] triggers the build failure, so in the below
> patch renaming mac as mac_buf is done, because it is used to print the mac
> address using the newly introduced print_mac function.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
parent reply other threads:[~2007-09-26 6:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200709242233.l8OMXsL5021125@imap1.linux-foundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925.230251.120461813.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®