mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mel@skynet.ie (Mel Gorman)
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, axboe@kernel.dk, neilb@suse.de,
	Geert.Uytterhoeven@sonycom.com, geoffrey.levand@am.sony.com
Subject: Re: 2.6.23-rc7-mm1
Date: Tue, 25 Sep 2007 11:23:56 +0100	[thread overview]
Message-ID: <20070925102356.GB8076@skynet.ie> (raw)
In-Reply-To: <46F812DF.4010909@linux.vnet.ibm.com>

On (25/09/07 01:11), Kamalesh Babulal didst pronounce:

Hi Kamalesh,

> The build fails with following error
> 
> CC drivers/block/ps3disk.o
> drivers/block/ps3disk.c: In function ???ps3disk_scatter_gather???:
> drivers/block/ps3disk.c:115: error: ???bio??? undeclared (first use in this
> function)
> drivers/block/ps3disk.c:115: error: (Each undeclared identifier is
> reported only once
> drivers/block/ps3disk.c:115: error: for each function it appears in.)
> drivers/block/ps3disk.c:115: error: ???j??? undeclared (first use in this
> function)
> drivers/block/ps3disk.c:116: error: implicit declaration of function
> ???bio_kunmap_bvec???
> make[2]: *** [drivers/block/ps3disk.o] Error 1
> make[1]: *** [drivers/block] Error 2
> make: *** [drivers] Error 2
> 
> The function bio_kunmap_bvec is missing.I tried checking the git-block.patch
> as well as the linux/kernel/git/axboe/linux-2.6-block.git and did not
> find this function.
> 
> Previously this function was replaced by __bio_kunmap_atomic();
> This patch does not solves the implicit "declaration of function
> ???bio_kunmap_bvec???"
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com
> <mailto:kamalesh@linux.vnet.ibm.com>>

Your mailer appears to have mangled both your signoff and the whitespace in
the patch and it does not apply. However, fixing it does not solve the problem
because of this mysterious bio_kunmap_bvec() that is only referenced by this
driver. Was it accidently added during the addition of sg chaining support?

> ---
> 
> --- linux-2.6.23-rc7/drivers/block/ps3disk.c    2007-09-24 20:50:41.000000000 +0530
> +++ linux-2.6.23-rc7/drivers/block/~ps3disk.c   2007-09-24 20:50:59.000000000 +0530
> @@ -112,7 +112,7 @@ static void ps3disk_scatter_gather(struc
>                 else
>                         memcpy(buf, dev->bounce_buf+offset, size);
>                 offset += size;
> -               flush_kernel_dcache_page(bio_iovec_idx(bio, j)->bv_page);
> +              flush_kernel_dcache_page(bio_iovec_idx(iter.bio, iter.i)->bv_page);
>                 bio_kunmap_bvec(bvec, flags);
>                 i++;
>         }
> 
> -- 
> 
> Thanks & Regards,
> Kamalesh Babulal,
> Linux Technology Center,
> IBM, ISTL.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

  reply	other threads:[~2007-09-25 10:24 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24  9:17 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 10:07 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 21:02   ` 2.6.23-rc7-mm1 Sam Ravnborg
2007-09-24 21:36     ` 2.6.23-rc7-mm1 Sam Ravnborg
2007-09-24 23:27       ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 10:35 ` 2.6.23-rc7-mm1 - 'touch' command causes Oops Valdis.Kletnieks
2007-09-24 11:08   ` Balbir Singh
2007-09-24 12:05   ` Christoph Hellwig
2007-09-24 12:58     ` Valdis.Kletnieks
2007-09-24 15:45       ` Dave Hansen
2007-09-24 16:08         ` Valdis.Kletnieks
2007-09-24 11:30 ` [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int WANG Cong
2007-09-24 22:18   ` Marcel Holtmann
2007-09-26  5:57     ` David Miller
2007-09-24 11:42 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 12:32 ` 2.6.23-rc7-mm1 -- s390 compile failures Andy Whitcroft
2007-09-24 12:49   ` Cedric Le Goater
2007-09-24 12:33 ` 2.6.23-rc7-mm1 Jiri Slaby
2007-09-24 14:41   ` [linux-usb-devel] 2.6.23-rc7-mm1 Alan Stern
2007-09-24 18:45     ` Jiri Slaby
2007-09-24 19:06       ` Alan Stern
2007-09-24 19:18         ` Jiri Slaby
2007-09-24 19:41           ` Alan Stern
2007-09-30  8:26             ` Jiri Slaby
2007-09-24 12:35 ` 2.6.23-rc7-mm1 -- powerpc rtas panic Andy Whitcroft
2007-10-02 23:28   ` Linas Vepstas
2007-10-03  0:26     ` Tony Breeds
2007-10-03  0:30       ` Michael Ellerman
2007-10-03  1:19         ` Tony Breeds
2007-10-03  4:09           ` Michael Ellerman
2007-10-03 18:50             ` Linas Vepstas
2007-10-05  0:01           ` Nish Aravamudan
2007-10-05 16:03             ` Linas Vepstas
2007-10-08  3:47               ` Nish Aravamudan
2007-09-24 12:47 ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 16:56   ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 12:55 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 13:10   ` 2.6.23-rc7-mm1 Pavel Emelyanov
2007-09-24 13:21     ` 2.6.23-rc7-mm1 Balbir Singh
2007-09-24 15:34       ` 2.6.23-rc7-mm1 Pavel Emelyanov
2007-09-24 16:10         ` 2.6.23-rc7-mm1 Balbir Singh
2007-09-24 13:00 ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 13:10   ` 2.6.23-rc7-mm1 Cedric Le Goater
2007-09-24 13:29     ` 2.6.23-rc7-mm1 Vlad Yasevich
2007-09-24 16:58       ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 16:57     ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 13:13 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 16:44   ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 16:57     ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-24 17:08       ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 19:20         ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-25 11:05           ` 2.6.23-rc7-mm1 Peter Zijlstra
2007-09-25 13:07             ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-24 13:17 ` [PATCH rc7-mm1] fix BUG at mm/swap.c:405! Hugh Dickins
2007-09-24 14:52 ` 2.6.23-rc7-mm1 Reuben Farrelly
2007-09-24 16:59   ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 17:12     ` 2.6.23-rc7-mm1 J. Bruce Fields
2007-09-24 21:31       ` 2.6.23-rc7-mm1 Reuben Farrelly
2007-09-24 15:18 ` 2.6.23-rc7-mm1 ia64 build issue in efi.c Bob Picco
2007-09-24 19:07 ` 2.6.23-rc7-mm1 Torsten Kaiser
2007-09-24 19:34   ` 2.6.23-rc7-mm1 Andrew Morton
2007-09-24 20:25     ` 2.6.23-rc7-mm1 Thomas Gleixner
2007-09-25  7:32       ` 2.6.23-rc7-mm1 Torsten Kaiser
2007-09-25  7:44         ` 2.6.23-rc7-mm1 Thomas Gleixner
2007-09-24 19:41 ` 2.6.23-rc7-mm1 Kamalesh Babulal
2007-09-25 10:23   ` Mel Gorman [this message]
2007-09-25 10:31     ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-25 11:15       ` 2.6.23-rc7-mm1 Mel Gorman
2007-09-25 11:23         ` 2.6.23-rc7-mm1 Jens Axboe
2007-09-24 20:10 ` 2.6.23-rc7-mm1: build error with CONFIG_KEXEC=y and CONFIG_NOHIGHMEM=y Laurent Riffard
2007-09-24 23:11   ` Randy Dunlap
2007-09-24 22:20 ` 2.6.23-rc7-mm1 Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070925102356.GB8076@skynet.ie \
    --to=mel@skynet.ie \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=geoffrey.levand@am.sony.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®