From: Randy Dunlap <rdunlap@xenotime.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Andy Whitcroft <apw@shadowen.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.10
Date: Fri, 28 Sep 2007 09:57:34 -0700 [thread overview]
Message-ID: <20070928095734.407ad4fc.rdunlap@xenotime.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0709281617430.25099@fbirervta.pbzchgretzou.qr>
On Fri, 28 Sep 2007 16:19:01 +0200 (CEST) Jan Engelhardt wrote:
>
> On Sep 28 2007 19:03, WANG Cong wrote:
> >
> >Maybe checkpatch.pl needs an option '-W' to turn on/off those vexed "noise".
> >(It seems that 'q|quiet' doesn't do as much as what it hints.)
>
> Make checkpatch.pl a C language parser, then it can handle
> all the whitespace violations without false positives. :-)
Well, yes, that's the root problem.
checkpatch is a regex tool, not a C parser.
And like Andy commented in another mail in this thread, (esp. since
it's not a C parser), it's just a guide.
---
~Randy
next prev parent reply other threads:[~2007-09-28 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 15:00 Andy Whitcroft
2007-09-28 8:40 ` Ingo Molnar
2007-09-28 9:01 ` Andrew Morton
2007-09-28 9:22 ` Andy Whitcroft
2007-09-28 9:39 ` Ingo Molnar
2007-09-28 10:00 ` Andy Whitcroft
2007-09-28 10:46 ` Christian Borntraeger
2007-09-28 11:03 ` WANG Cong
2007-09-28 14:19 ` Jan Engelhardt
2007-09-28 16:57 ` Randy Dunlap [this message]
2007-09-28 10:49 ` Ingo Molnar
2007-09-28 13:21 ` Andy Whitcroft
2007-09-28 13:37 ` Pekka Enberg
2007-09-28 14:02 ` Andy Whitcroft
2007-09-28 15:50 ` Joel Schopp
2007-09-28 17:26 ` Randy Dunlap
2007-09-28 17:46 ` Andrew Morton
2007-09-29 9:22 ` Andy Whitcroft
2007-10-05 5:56 ` Ingo Molnar
2007-09-28 16:51 ` Sam Ravnborg
2007-09-28 9:44 ` Ingo Molnar
2007-09-28 9:52 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928095734.407ad4fc.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=borntraeger@de.ibm.com \
--cc=jengelh@computergmbh.de \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®