From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755707AbXI1Taf (ORCPT ); Fri, 28 Sep 2007 15:30:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751397AbXI1Ta1 (ORCPT ); Fri, 28 Sep 2007 15:30:27 -0400 Received: from stout.engsoc.carleton.ca ([134.117.69.22]:57522 "EHLO stout.engsoc.carleton.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbXI1Ta1 (ORCPT ); Fri, 28 Sep 2007 15:30:27 -0400 Date: Fri, 28 Sep 2007 15:30:24 -0400 From: Kyle McMartin To: Arnd Bergmann Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] Generic compat_sys_fallocate Message-ID: <20070928193024.GB24047@fattire.cabal.ca> References: <20070928181111.GF22182@fattire.cabal.ca> <200709282101.39020.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200709282101.39020.arnd@arndb.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2007 at 09:01:37PM +0200, Arnd Bergmann wrote: > > This code assumes little-endian register ordering for 64 bit > arguments. AFAICS, this is wrong at aleast on mipseb and powerpc. > Yeah, you're right. I've an idea for how to fix this, will update patch soon. Cheers, Kyle