From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbXJAOOh (ORCPT ); Mon, 1 Oct 2007 10:14:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751823AbXJAOO3 (ORCPT ); Mon, 1 Oct 2007 10:14:29 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:57838 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbXJAOO2 (ORCPT ); Mon, 1 Oct 2007 10:14:28 -0400 Date: Mon, 1 Oct 2007 09:14:26 -0500 From: "Serge E. Hallyn" To: "Robert P. J. Day" Cc: Pavel Emelyanov , Cedric Le Goater , Andrew Morton , Serge Hallyn , "Eric W. Biederman" , Linux Containers , Linux Kernel Mailing List Subject: Re: [PATCH 4/5] Move the user namespace under the option Message-ID: <20071001141426.GB30599@sergelap.austin.ibm.com> References: <46FA7D4D.8040808@openvz.org> <46FA8087.6060307@openvz.org> <46FBA2A4.2040909@fr.ibm.com> <4700A7C5.5080005@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Quoting Robert P. J. Day (rpjday@mindspring.com): > On Mon, 1 Oct 2007, Pavel Emelyanov wrote: > > > Robert P. J. Day wrote: > > > On Thu, 27 Sep 2007, Cedric Le Goater wrote: > > > > > >>> diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h > > >>> index b5f41d4..dda160c 100644 > > >>> --- a/include/linux/user_namespace.h > > >>> +++ b/include/linux/user_namespace.h > > >>> @@ -17,7 +17,7 @@ struct user_namespace { > > >>> > > >>> extern struct user_namespace init_user_ns; > > >>> > > >>> -#ifdef CONFIG_USER_NS > > >>> +#ifdef CONFIG_NAMESPACES_EXPERIMENTAL > > > > > > is it really a good precedent to introduce Kconfig variables that > > > literally include the word "EXPERIMENTAL"? > > > > How else can we call it? I proposed one config option for each > > namespace with "depends on EXPERIMENTAL" dependency, but everyone > > else said that two options are much better. > > i don't know -- perhaps something as trivially obvious as > NAMESPACES_V2 or something. i just think it's awkward to take a word > like "EXPERIMENTAL" that already has a long and established history, > and start jamming it into config variable names. but it's just an > observation. But these really are EXPERIMENTAL, not just 'v2'. They are not yet safe to use except for testing. Once they are more complete and safe to use, they will fall under just CONFIG_NAMESPACES. -serge