From: Arjan van de Ven <arjan@infradead.org>
To: Kirill Korotaev <dev@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH] mark read_crX() asm code as volatile
Date: Tue, 2 Oct 2007 08:28:56 -0700 [thread overview]
Message-ID: <20071002082856.3c478e66@laptopd505.fenrus.org> (raw)
In-Reply-To: <470250E0.5090706@openvz.org>
On Tue, 02 Oct 2007 18:08:32 +0400
Kirill Korotaev <dev@openvz.org> wrote:
> Some gcc versions (I checked at least 4.1.1 from RHEL5 & 4.1.2 from
> gentoo) can generate incorrect code with read_crX()/write_crX()
> functions mix up, due to cached results of read_crX().
>
I'm not so sure volatile is the right answer, as compared to giving the
asm more strict contraints....
asm volatile tends to mean something else than "the result has
changed"....
next prev parent reply other threads:[~2007-10-02 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 14:08 Kirill Korotaev
2007-10-02 14:17 ` Andi Kleen
2007-10-02 15:28 ` Arjan van de Ven [this message]
2007-10-02 18:27 ` Chuck Ebbert
2007-10-02 12:14 ` Nick Piggin
2007-10-03 6:18 ` H. Peter Anvin
2007-10-02 15:49 ` Nick Piggin
2007-10-03 8:45 ` Andi Kleen
2007-10-02 19:21 ` H. Peter Anvin
2007-10-03 8:25 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002082856.3c478e66@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®