mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Willy Tarreau <w@1wt.eu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@shadowen.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] printk: add KERN_CONT annotation
Date: Tue, 2 Oct 2007 12:04:42 +0200	[thread overview]
Message-ID: <20071002100441.GB5361@lazybastard.org> (raw)
In-Reply-To: <20071002051852.GC28345@elte.hu>

On Tue, 2 October 2007 07:18:52 +0200, Ingo Molnar wrote:
> 
> ah, this is even nicer than the raw_printk() thing i suggested, and it 
> also nicely documents the intention of the author. Patch attached below.

KERN_CONT was brought up in the linux-tiny discussion.  Not sure if you
want to get involved in that, but there may be value in adding one
variant of KERN_CONT per debug level:
http://lkml.org/lkml/2007/9/30/151

> And i'd like to stress the principle that is followed here: in this 
> particular case the checkpatch.pl warning is very useful, but still 
> there are false positives. Fortunately they are so rare that it's worth 
> annotating those few exceptions in the source. Note that the goal is 
> still to be able to achieve 100% warning-free source code. _That_ should 
> be the driving principle behind checkpatch.pl warnings.

Thank you for working on this.  I had nearly given up on checkpatch
before.

Jörn

-- 
When people work hard for you for a pat on the back, you've got
to give them that pat.
-- Robert Heinlein

  reply	other threads:[~2007-10-02 10:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070928105345.GC18163@shadowen.org>
2007-10-01  6:44 ` checkpatch and kernel/sched.c Ingo Molnar
2007-10-01  7:30   ` Andrew Morton
2007-10-01  7:48     ` Avi Kivity
2007-10-01  7:39       ` Andrew Morton
2007-10-01 10:39         ` Ingo Molnar
2007-10-01  7:50     ` Sam Ravnborg
2007-10-01 10:37     ` Ingo Molnar
2007-10-01 10:44     ` Ingo Molnar
2007-10-01 12:34     ` Andy Whitcroft
2007-10-02  4:34     ` Willy Tarreau
2007-10-02  5:18       ` [patch] printk: add KERN_CONT annotation Ingo Molnar
2007-10-02 10:04         ` Jörn Engel [this message]
2007-10-02 15:41         ` Joe Perches
2007-10-02 15:45           ` Jan Engelhardt
2007-10-02 16:03             ` Joe Perches
2007-10-02 16:07               ` Jan Engelhardt
2007-10-04 20:43         ` Andrew Morton
2007-10-04 20:52           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071002100441.GB5361@lazybastard.org \
    --to=joern@logfs.org \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®