From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
linux-kernel@vger.kernel.org, dada1@cosmosbay.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/2] getattr - fill the size of pipes
Date: Fri, 5 Oct 2007 00:41:49 +0100 [thread overview]
Message-ID: <20071005004149.0c9746dc@the-village.bc.nu> (raw)
In-Reply-To: <20071004162252.f0785c9f.akpm@linux-foundation.org>
> Cute feature, but it is (I assume) a Linux-specific extension and is
> something which we'll need to maintain for ever and it invites
Actually it used to work on the old old Linux pipe code.
> unportability to older Linuxes and other OSes and it introduces some risk
> of breakage of existing applications. And it slows down fstat on a pipe.
Most Sys5 based boxes happen to put the right value there but not
everyone and its not guaranteed in the slightest
>
> Given that the info can already be obtained via ioctl(FIONREAD) anyway, I
> don't think that (gain > pain)?
Nor me - any application trying to reduce the syscall count would just do
a very large read and get the data and size in one go.
prev parent reply other threads:[~2007-10-04 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 17:54 Jan Engelhardt
2007-10-02 17:55 ` [patch 2/2] getattr - fill the size of FIFOs Jan Engelhardt
2007-10-04 23:22 ` [patch 1/2] getattr - fill the size of pipes Andrew Morton
2007-10-04 23:41 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005004149.0c9746dc@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=jengelh@computergmbh.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®