From: Andi Kleen <ak@suse.de>
To: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: [PATCH] [6/6] scheduler: Remove bogus comment in sched_group_set_shares
Date: Sun, 7 Oct 2007 22:59:59 +0200 (CEST) [thread overview]
Message-ID: <20071007205959.8BBD11474B@wotan.suse.de> (raw)
In-Reply-To: <200710071059.126674000@suse.de>
Function never returns -EINVAL.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux-2.6-sched-devel/kernel/sched.c
===================================================================
--- linux-2.6-sched-devel.orig/kernel/sched.c
+++ linux-2.6-sched-devel/kernel/sched.c
@@ -6814,8 +6814,6 @@ int sched_group_set_shares(struct task_g
if (tg->shares == shares)
return 0;
- /* return -EINVAL if the new value is not sane */
-
tg->shares = shares;
for_each_possible_cpu(i)
set_se_shares(tg->se[i], shares);
next prev parent reply other threads:[~2007-10-07 21:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 20:59 [PATCH] [0/6] Some scheduler changes for sched-devel Andi Kleen
2007-10-07 20:59 ` [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c Andi Kleen
2007-10-08 11:36 ` Ingo Molnar
2007-10-09 19:17 ` Ingo Molnar
2007-10-10 0:55 ` Andi Kleen
2007-10-10 11:25 ` Ingo Molnar
2007-10-10 11:26 ` Ingo Molnar
2007-10-07 20:59 ` [PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion Andi Kleen
2007-10-07 22:22 ` [PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion v2 Andi Kleen
2007-10-08 11:39 ` Ingo Molnar
2007-10-08 12:03 ` Ingo Molnar
2007-10-07 20:59 ` [PATCH] [3/6] scheduler: Do devirtualization for sched_fair Andi Kleen
2007-10-08 11:42 ` Ingo Molnar
2007-10-08 12:32 ` Andi Kleen
2007-10-08 12:39 ` Ingo Molnar
2007-10-08 14:33 ` Andi Kleen
2007-10-07 20:59 ` [PATCH] [4/6] scheduler: Refactor normalize_rt_tasks Andi Kleen
2007-10-08 11:44 ` Ingo Molnar
2007-10-07 20:59 ` [PATCH] [5/6] scheduler: Protect important kernel threads against normalize_rt Andi Kleen
2007-10-08 11:51 ` Ingo Molnar
2007-10-08 12:33 ` Andi Kleen
2007-10-08 12:43 ` Ingo Molnar
2007-10-08 13:08 ` Andi Kleen
2007-10-07 20:59 ` Andi Kleen [this message]
2007-10-08 11:52 ` [PATCH] [6/6] scheduler: Remove bogus comment in sched_group_set_shares Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007205959.8BBD11474B@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome