From: Gregory Haskins <ghaskins@novell.com>
To: mingo@elte.hu, linux-rt-users@vger.kernel.org, rostedt@goodmis.org
Cc: kravetz@us.ibm.com, linux-kernel@vger.kernel.org,
ghaskins@novell.com, pmorreale@novell.com, sdietrich@novell.com
Subject: [PATCH 4/5] RT: Add a per-cpu rt_overload indication
Date: Tue, 09 Oct 2007 10:26:05 -0400 [thread overview]
Message-ID: <20071009142605.4941.95952.stgit@novell1.haskins.net> (raw)
In-Reply-To: <20071009142044.4941.65189.stgit@novell1.haskins.net>
The system currently evaluates all online CPUs whenever one or more enters
an rt_overload condition. This suffers from scalability limitations as
the # of online CPUs increases. So we introduce a cpumask to track
exactly which CPUs need RT balancing.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
CC: Peter W. Morreale <pmorreale@novell.com>
---
kernel/sched.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 551629b..a28ca9d 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -631,6 +631,7 @@ static inline struct rq *this_rq_lock(void)
#if defined(CONFIG_PREEMPT_RT) && defined(CONFIG_SMP)
static __cacheline_aligned_in_smp atomic_t rt_overload;
+static cpumask_t rto_cpus;
#endif
static inline void inc_rt_tasks(struct task_struct *p, struct rq *rq)
@@ -639,8 +640,11 @@ static inline void inc_rt_tasks(struct task_struct *p, struct rq *rq)
if (rt_task(p)) {
rq->rt_nr_running++;
# ifdef CONFIG_SMP
- if (rq->rt_nr_running == 2)
+ if (rq->rt_nr_running == 2) {
+ cpu_set(rq->cpu, rto_cpus);
+ smp_wmb();
atomic_inc(&rt_overload);
+ }
# endif
}
#endif
@@ -653,8 +657,10 @@ static inline void dec_rt_tasks(struct task_struct *p, struct rq *rq)
WARN_ON(!rq->rt_nr_running);
rq->rt_nr_running--;
# ifdef CONFIG_SMP
- if (rq->rt_nr_running == 1)
+ if (rq->rt_nr_running == 1) {
atomic_dec(&rt_overload);
+ cpu_clear(rq->cpu, rto_cpus);
+ }
# endif
}
#endif
@@ -1503,7 +1509,7 @@ static void balance_rt_tasks(struct rq *this_rq, int this_cpu)
*/
next = pick_next_task(this_rq, this_rq->curr);
- for_each_online_cpu(cpu) {
+ for_each_cpu_mask(cpu, rto_cpus) {
if (cpu == this_cpu)
continue;
src_rq = cpu_rq(cpu);
next prev parent reply other threads:[~2007-10-09 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 14:25 [PATCH 0/5] RT: scheduler fixes and rt_overload enhancements Gregory Haskins
2007-10-09 14:25 ` [PATCH 1/5] RT - fix for scheduling issue Gregory Haskins
2007-10-09 14:25 ` [PATCH 2/5] RT - fix reschedule IPI Gregory Haskins
2007-10-09 14:25 ` [PATCH 3/5] RT - fix mistargeted RESCHED_IPI Gregory Haskins
2007-10-09 14:26 ` Gregory Haskins [this message]
2007-10-09 14:26 ` [PATCH 5/5] RT - Track which CPUs should get IPI'd on rt-overload Gregory Haskins
2007-10-09 15:00 ` [PATCH 0/5] RT: scheduler fixes and rt_overload enhancements Peter Zijlstra
2007-10-09 15:00 ` Steven Rostedt
2007-10-09 15:33 ` Gregory Haskins
2007-10-09 15:39 ` Peter Zijlstra
2007-10-09 17:59 ` [RFC PATCH RT] push waiting rt tasks to cpus with lower prios Steven Rostedt
2007-10-09 18:14 ` Steven Rostedt
2007-10-09 18:16 ` Peter Zijlstra
2007-10-09 18:45 ` Steven Rostedt
2007-10-09 20:39 ` mike kravetz
2007-10-09 20:50 ` Steven Rostedt
2007-10-09 21:17 ` mike kravetz
2007-10-10 2:12 ` Girish kathalagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009142605.4941.95952.stgit@novell1.haskins.net \
--to=ghaskins@novell.com \
--cc=kravetz@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pmorreale@novell.com \
--cc=rostedt@goodmis.org \
--cc=sdietrich@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®