From: Luca Risolia <luca.risolia@studio.unibo.it>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, mchehab@infradead.org,
video4linux-list@redhat.com
Subject: Re: [PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS
Date: Wed, 10 Oct 2007 02:18:50 +0200 [thread overview]
Message-ID: <200710100218.50987.luca.risolia@studio.unibo.it> (raw)
In-Reply-To: <11237258561195029635@pripojeni.net>
acked-by: Luca Risolia <luca.risolia@studio.unibo.it>
On Monday 08 October 2007 14:40:53 Jiri Slaby wrote:
> zc0301, remove bad usage of ERESTARTSYS
>
> down_read_trylock can't be interrupted and so ERESTARTSYS would reach
> userspace, which is not permitted. Change it to EAGAIN
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
> commit 235cf594bc65128250632a642f3e9d7e4df4975e
> tree 0557746416827daeb4d829610fec2f0c9111a675
> parent db38c559d37219c32b179ae005ca7e489336ec94
> author Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:15:47 +0200
> committer Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:15:47 +0200
>
> drivers/media/video/zc0301/zc0301_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/zc0301/zc0301_core.c
> b/drivers/media/video/zc0301/zc0301_core.c index 35138c5..08a93c3 100644
> --- a/drivers/media/video/zc0301/zc0301_core.c
> +++ b/drivers/media/video/zc0301/zc0301_core.c
> @@ -655,7 +655,7 @@ static int zc0301_open(struct inode* inode, struct
> file* filp) int err = 0;
>
> if (!down_read_trylock(&zc0301_dev_lock))
> - return -ERESTARTSYS;
> + return -EAGAIN;
>
> cam = video_get_drvdata(video_devdata(filp));
next prev parent reply other threads:[~2007-10-10 0:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 12:33 [PATCH 1/3] V4L: w9968cf, " Jiri Slaby
2007-10-08 12:34 ` [PATCH 2/3] V4L: zc0301, " Jiri Slaby
2007-10-10 0:18 ` Luca Risolia [this message]
2007-10-08 12:34 ` [PATCH 3/3] V4L: cinergyT2, " Jiri Slaby
2007-10-10 1:21 ` Mauro Carvalho Chehab
2007-10-10 4:18 ` [v4l-dvb-maintainer] " Michael Krufky
2007-10-10 15:35 ` Mauro Carvalho Chehab
2007-10-10 15:59 ` Alan Cox
2007-10-10 16:17 ` Mauro Carvalho Chehab
2007-10-10 16:40 ` Manu Abraham
2007-10-10 16:53 ` Marcel Siegert
2007-10-10 17:05 ` Manu Abraham
2007-10-10 18:04 ` Marcel Siegert
2007-10-12 4:29 ` Randy Dunlap
2007-10-10 0:18 ` [PATCH 1/3] V4L: w9968cf, " Luca Risolia
2007-10-14 14:28 ` [PATCH 1/1 try 2] V4L: cinergyT2, " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710100218.50987.luca.risolia@studio.unibo.it \
--to=luca.risolia@studio.unibo.it \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®