From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mm-commits@vger.kernel.org, heiko.carstens@de.ibm.com,
schwidefsky@de.ibm.com
Subject: Re: [PATCH net-2.6.24] remove bogus qeth type check
Date: Thu, 11 Oct 2007 14:46:13 -0700 (PDT) [thread overview]
Message-ID: <20071011.144613.48517852.davem@davemloft.net> (raw)
In-Reply-To: <20071011132458.3b536662@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 11 Oct 2007 13:24:58 -0700
[ SOrry, I just noticed this was different... ]
> Not sure why this crept in with hard-header-ops change.
> Just kill it. Need to start doing cross-compiles for s390...
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> --- a/drivers/s390/net/qeth_main.c 2007-10-10 08:26:48.000000000 -0700
> +++ b/drivers/s390/net/qeth_main.c 2007-10-11 13:21:17.000000000 -0700
> @@ -6581,9 +6581,6 @@ qeth_hard_header_parse(const struct sk_b
> const struct qeth_card *card;
> const struct ethhdr *eth;
>
> - if (dev->type != ARPHRD_IEEE802_TR)
> - return 0;
> -
> card = qeth_get_card_from_dev(skb->dev);
> if (card->options.layer2)
> goto haveheader;
I think you copied the check from another part of the driver.
Perhaps you should double check before we kill this outright.
next prev parent reply other threads:[~2007-10-11 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200710110909.l9B99fEM021646@imap1.linux-foundation.org>
2007-10-11 9:45 ` + git-net-fix-qeth_main.patch added to -mm tree David Miller
2007-10-11 20:24 ` [PATCH net-2.6.24] remove bogus qeth type check Stephen Hemminger
2007-10-11 21:44 ` David Miller
2007-10-11 21:46 ` David Miller [this message]
2007-10-12 0:24 ` David Miller
2007-10-12 0:52 ` Stephen Hemminger
2007-10-12 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011.144613.48517852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®