From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761555AbXJMAbc (ORCPT ); Fri, 12 Oct 2007 20:31:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760632AbXJMA3V (ORCPT ); Fri, 12 Oct 2007 20:29:21 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:55842 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760796AbXJMA3U (ORCPT ); Fri, 12 Oct 2007 20:29:20 -0400 Date: Fri, 12 Oct 2007 17:29:17 -0700 From: "Darrick J. Wong" To: "Mark M. Hoffman" Cc: Jean Delvare , Henrique de Moraes Holschuh , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, haveblue@us.ibm.com Subject: Re: [PATCH v4] IBM power meter driver Message-ID: <20071013002917.GO16752@tree.beaverton.ibm.com> References: <20070827211446.GG32667@tree.beaverton.ibm.com> <20070828015029.GA10107@khazad-dum.debian.net> <20070828131942.18449886@hyperion.delvare> <20070828164905.GM32667@tree.beaverton.ibm.com> <20070828232504.GP32667@tree.beaverton.ibm.com> <20070911132335.GJ31992@jupiter.solarsys.private> <20070914193346.GM30825@tree.beaverton.ibm.com> <20071009120044.GP3835@jupiter.solarsys.private> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yQDbd2FCF2Yhw41T" Content-Disposition: inline In-Reply-To: <20071009120044.GP3835@jupiter.solarsys.private> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org --yQDbd2FCF2Yhw41T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 09, 2007 at 08:00:44AM -0400, Mark M. Hoffman wrote: > Sorry it took me so long to get back to this. I've applied this to my hwmon > testing branch, but I would still like to get a review from an IPMI expert. I'm working on finding somebody to do that. > OBTW: please try to send patches which apply cleanly to some tree to which I > have access. E.g. from the Makefile - preceding and trailing context are not > present in any git tree that I know. Oops, sorry about that. The i5k_amb driver referenced in the Makefile diff is the same one that I posted to lm-sensors a few weeks ago, though there hasn't been much discussion after it was pointed out that someone had already written a driver to achieve the same purpose. Unfortunately, nothing's happened to either driver; any thoughts? I'm thinking that we ought to get one of them into shape for upstream, though I don't particularly care which one it is... --D --yQDbd2FCF2Yhw41T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHEBFda6vRYYgWQuURAjPXAKCTgW3HhKqRSYcacX46VeqlhnX4qQCfb43d co8Oq8BASFJBcVCOyQvoeEs= =3o+h -----END PGP SIGNATURE----- --yQDbd2FCF2Yhw41T--