mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Giacomo Catenazzi <cate@debian.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.23.git build error
Date: Sat, 13 Oct 2007 10:17:59 +0200	[thread overview]
Message-ID: <20071013081759.GB28168@uranus.ravnborg.org> (raw)
In-Reply-To: <1192260909.7369.20.camel@Homer.simpson.net>

On Sat, Oct 13, 2007 at 09:35:09AM +0200, Mike Galbraith wrote:
> On Sat, 2007-10-13 at 09:16 +0200, Sam Ravnborg wrote:
> 
> > Pulled 2.6.23 tree and did a build
> > Added latest -linus on top of it.
> > Did a new build (x86_64).
> > 
> > 
> > As expected it failed due to wrong asm symlink but nothing
> > like the error Mike posted.
> > So I'm a bit puzzeled here.
> > 
> > I anyone can explain how to reproduce it I will chase it
> > but otherwise it will be left as a "consequence of
> > the x86 merge".
> 
> What I did was to pull, then diff against my working tree (/me=SCM
> weenie;) for review as usual, and then apply that diff to working tree
> and make oldconfig as usual.  That left me with the same failure this
> morning, despite the file being verified present in the git tree.  I
> then used git-archive --format=tar | (cd work_tree;tar -xvf -).  That
> spewed chunks when I tried to build it even though diff said the trees
> were identical.  After make mrproper and restoring my saved .config, all
> was peachy.
> 
> Methinks dontdiff bit me.

After a quick look:
[sam@neptun x86.git]$ find -name '*.i'
./include/asm-x86/alternative-asm_64.i
./include/asm-x86/alternative-asm_32.i
./include/asm-x86/frame.i
./include/asm-x86/alternative-asm.i
./include/asm-um/frame.i
./include/asm-um/alternative-asm.i
[sam@neptun x86.git]$ grep '*.i' Documentation/dontdiff 
*.i

But I cannot see how this could result in the bug you
reported..
Anyway at least one dontdiff buglet - or we should preferably
drop the .i files in the kernel src.

	Sam

  reply	other threads:[~2007-10-13  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  4:48 Mike Galbraith
2007-10-12 21:31 ` Sam Ravnborg
2007-10-13  3:34   ` Mike Galbraith
2007-10-13  5:40     ` Giacomo Catenazzi
2007-10-13  7:16       ` Sam Ravnborg
2007-10-13  7:35         ` Mike Galbraith
2007-10-13  8:17           ` Sam Ravnborg [this message]
2007-10-13  9:44             ` Thomas Gleixner
     [not found]             ` <1192608832.30373.5.camel@Homer.simpson.net>
2007-10-17 20:06               ` [PATCH] x86: delete vsyscall files during make clean Sam Ravnborg
2007-10-17 20:09                 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071013081759.GB28168@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=cate@debian.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®