From: Hans Verkuil <hverkuil@xs4all.nl>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] ivtv: fix NULL dereference
Date: Sun, 14 Oct 2007 20:03:20 +0200 [thread overview]
Message-ID: <200710142003.20323.hverkuil@xs4all.nl> (raw)
In-Reply-To: <20071014175137.GM4211@stusta.de>
On Sunday 14 October 2007 19:51:37 Adrian Bunk wrote:
> We shouldn't dereference "itv" when we know it's NULL...
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> --- linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c.old 2007-10-14
> 19:17:12.000000000 +0200 +++
> linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c 2007-10-14
> 19:18:05.000000000 +0200 @@ -947,7 +947,7 @@ int
> ivtv_v4l2_open(struct inode *inode,
> if (itv == NULL) {
> /* Couldn't find a device registered
> on that minor, shouldn't happen! */
> - IVTV_WARN("No ivtv device found on minor %d\n", minor);
> + printk(KERN_WARNING "No ivtv device found on minor %d\n", minor);
> return -ENXIO;
> }
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Luckily this is something that 'shoudn't happen' :-)
Oddly enough it is correct in my standalone driver.
Mauro, can you merge this with 2.6.24 as well? Or shall I add it to my
ivtv tree with my other outstanding fixes?
Regards,
Hans
next prev parent reply other threads:[~2007-10-14 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 17:51 Adrian Bunk
2007-10-14 18:03 ` Hans Verkuil [this message]
2007-10-15 18:01 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710142003.20323.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®