From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: aarapov@redhat.com, linux-kernel@vger.kernel.org,
linux-netdev@vger.kernel.org, davem@redhat.com,
jgarzik@redhat.com
Subject: Re: [PATCH] ipv4: kernel panic when only one unsecured port available
Date: Mon, 15 Oct 2007 13:06:14 -0700 (PDT) [thread overview]
Message-ID: <20071015.130614.129757419.davem@davemloft.net> (raw)
In-Reply-To: <20071015124919.30ed8f06.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 15 Oct 2007 12:49:19 -0700
> This code has recently been reworked, but from my reading, that
> divide-by-zero can still occur. And given that the numbers in
> /proc/sys/net/ipv4/ip_local_port_range are inclusive, the arithmetic in
> inet_csk_get_port() seems to just be wrong?
>
> So we have this, against David's current devel tree:
I'm pretty sure we took care of this, but maybe not :-)
next prev parent reply other threads:[~2007-10-15 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 13:59 Anton Arapov
2007-10-15 19:49 ` Andrew Morton
2007-10-15 20:06 ` David Miller [this message]
2007-10-15 21:00 ` Andrew Morton
2007-10-16 5:59 ` Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015.130614.129757419.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aarapov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@redhat.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome