mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	shemminger@linux-foundation.org, jgarzik@pobox.com
Subject: Re: [patch] forcedeth: fix the NAPI poll function
Date: Mon, 15 Oct 2007 15:39:53 -0700 (PDT)	[thread overview]
Message-ID: <20071015.153953.106262983.davem@davemloft.net> (raw)
In-Reply-To: <20071015223009.GA27425@elte.hu>

From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 16 Oct 2007 00:30:09 +0200

> Subject: forcedeth: fix the NAPI poll function
> From: Ingo Molnar <mingo@elte.hu>
> 
> fix the forcedeth NAPI poll function to not emit this warning:
> 
> [  186.635916] WARNING: at net/core/dev.c:2166 net_rx_action()
> [  186.641351]  [<c060d9f5>] net_rx_action+0x145/0x1b0
> [  186.646191]  [<c011d752>] __do_softirq+0x42/0x90
> [  186.650784]  [<c011d7c6>] do_softirq+0x26/0x30
> [  186.655202]  [<c011db48>] local_bh_enable+0x48/0xa0
> [  186.660055]  [<c06023e0>] lock_sock_nested+0xa0/0xc0
> [  186.664995]  [<c065da16>] tcp_recvmsg+0x16/0xbc0
> [  186.669588]  [<c013e94b>] __generic_file_aio_write_nolock+0x27b/0x520
> [  186.676001]  [<c0601d75>] sock_common_recvmsg+0x45/0x70
> [  186.681202]  [<c05ff5df>] sock_aio_read+0x11f/0x140
> [  186.686054]  [<c015c086>] do_sync_read+0xc6/0x110
> [  186.690735]  [<c012b9b0>] autoremove_wake_function+0x0/0x40
> [  186.696280]  [<c060dcfc>] net_tx_action+0x3c/0xe0
> [  186.700961]  [<c015c9c2>] vfs_read+0x132/0x140
> [  186.705378]  [<c015cd41>] sys_read+0x41/0x70
> [  186.709625]  [<c0102b66>] sysenter_past_esp+0x5f/0x89
> [  186.714651]  =======================
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

Excellent catch:

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2007-10-15 22:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 11:24 WARNING: at net/core/dev.c:2161 net_rx_action() Ingo Molnar
2007-10-15 11:27 ` Ingo Molnar
2007-10-15 16:18   ` Ingo Molnar
2007-10-15 19:57 ` David Miller
2007-10-15 22:03   ` Ingo Molnar
2007-10-15 22:07     ` Ingo Molnar
2007-10-15 22:21       ` David Miller
2007-10-15 22:30       ` [patch] forcedeth: fix the NAPI poll function Ingo Molnar
2007-10-15 22:39         ` David Miller [this message]
2007-10-15 22:40         ` Jeff Garzik
2007-10-15 22:41           ` Jeff Garzik
2007-10-16  5:42           ` Ingo Molnar
2007-10-16  5:47             ` Jeff Garzik
2007-10-16  6:40               ` Ingo Molnar
2007-10-16  7:17                 ` Jeff Garzik
2007-10-16  7:49                   ` Ingo Molnar
2007-10-16 16:52                     ` Jeff Garzik
2007-10-16 21:20         ` Jeff Garzik
2007-10-17  7:25           ` Ingo Molnar
2007-10-17 10:18             ` [patch] forcedeth: fix the NAPI poll function, take #2 Ingo Molnar
2007-10-18  0:21               ` Jeff Garzik
2007-10-15 22:18     ` WARNING: at net/core/dev.c:2161 net_rx_action() David Miller
2007-10-15 22:20     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015.153953.106262983.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=shemminger@linux-foundation.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome