From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting
Date: Mon, 15 Oct 2007 12:51:12 +0200 [thread overview]
Message-ID: <200710151251.12981.borntraeger@de.ibm.com> (raw)
In-Reply-To: <46E550D7.6090805@bull.net>
Am Montag, 10. September 2007 schrieb Laurent Vivier:
> The aim of these four patches is to introduce Virtual Machine time accounting.
I would move this line
if (p->flags & PF_VCPU) {
account_guest_time(p, cputime);
------> p->flags &= ~PF_VCPU; <---------
return;
}
into kvm_guest_exit. Otherwise a guest that is running very long in
guest context would only get the first tick accounted as guest time, no?
Besides that, this looks good and should work for kvm on s390 as well.
Thanks Laurent.
Christian
prev parent reply other threads:[~2007-10-15 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 14:12 Laurent Vivier
2007-09-10 19:37 ` Rik van Riel
2007-09-10 19:41 ` Ingo Molnar
2007-09-11 9:38 ` Laurent Vivier
2007-09-11 18:59 ` Rik van Riel
2007-09-11 14:05 ` Rik van Riel
2007-10-15 10:51 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710151251.12981.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=Laurent.Vivier@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome