Re: [PATCH 11/11] maps3: make page monitoring /proc file optional

[Matt Mackall <mpm@selenic.com>]

On Tue, Oct 16, 2007 at 10:03:39AM +1000, Rusty Russell wrote:
> On Tuesday 16 October 2007 08:51:17 Jeremy Fitzhardinge wrote:
> > Dave Hansen wrote:
> > > On Mon, 2007-10-15 at 17:26 -0500, Matt Mackall wrote:
> > >> +config PROC_PAGE_MONITOR
> > >> +       default y
> > >> +       bool "Enable /proc page monitoring" if EMBEDDED && PROC_FS &&
> > >> MMU +       help
> > >> +         Various /proc files exist to monitor process memory
> > >> utilization: +         /proc/pid/smaps, /proc/pid/clear_refs,
> > >> /proc/pid/pagemap, +         /proc/kpagecount, and /proc/kpageflags.
> > >> Disabling these +          interfaces will reduce the size of the kernel
> > >> by approximately 4kb.
> > >
> > > How about pulling the EMBEDDED off there?  I certainly want it for
> > > non-embedded reasons. ;)
> >
> > That means it will only bother asking you if you've set EMBEDDED;
> > otherwise its always on.
> 
> But it's at the least confusing.  Surely this option should depend on MMU and 
> PROC_FS, and the prompt depend on EMBEDDED?
> 
> That might be implied by the Kconfig layout, but AFAICT this patch removed the 
> explicit MMU dependency.
> 
> Rusty.

Wasn't this your patch? You're right, it ought to say "depends PROC_FS
&& MMU". Will fix.

-- 
Mathematics is the supreme nostalgia of our time.