From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932863AbXJPGk6 (ORCPT ); Tue, 16 Oct 2007 02:40:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761446AbXJPGkv (ORCPT ); Tue, 16 Oct 2007 02:40:51 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40727 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754435AbXJPGku (ORCPT ); Tue, 16 Oct 2007 02:40:50 -0400 Date: Tue, 16 Oct 2007 08:40:26 +0200 From: Ingo Molnar To: Jeff Garzik Cc: David Miller , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, shemminger@linux-foundation.org Subject: Re: [patch] forcedeth: fix the NAPI poll function Message-ID: <20071016064026.GA9578@elte.hu> References: <20071015112430.GA30006@elte.hu> <20071015.125731.79447899.davem@davemloft.net> <20071015220357.GA7174@elte.hu> <20071015220720.GA16101@elte.hu> <20071015223009.GA27425@elte.hu> <4713EC59.4010106@pobox.com> <20071016054236.GA27906@elte.hu> <47145075.1080003@garzik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47145075.1080003@garzik.org> User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Jeff Garzik wrote: > >>The compiler certainly doesn't care, and IMO it prevents bugs. > > > >agreed. Do you have an uptodate patch/git-URI for the forcedeth > >rewrite you did? I can throw it into the testbed. > > Branch 'fe-lock' of > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > > It works here locally, but at this very minute I am rewriting those > changesets yet again :) FYI, looks good so far, ontop of Linus' latest -git tree. btw., one thing i always found weird about forcedeth is that it generates an extra ~100 irqs per second even when there's no network traffic: 11: 89752 XT-PIC-XT eth0 11: 89854 XT-PIC-XT eth0 11: 89955 XT-PIC-XT eth0 11: 90056 XT-PIC-XT eth0 11: 90157 XT-PIC-XT eth0 (irq count snapshot every second). Just in case it's easy to fix ... Ingo