mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Vladislav Bolkhovitin <vst@vlnb.net>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: r8169 & TX offload
Date: Tue, 16 Oct 2007 19:25:17 +0200	[thread overview]
Message-ID: <20071016172517.GA8120@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <4714D785.3000402@vlnb.net>

(please remove l-k from the Cc:, this ought to be sent to netdev)

Vladislav Bolkhovitin <vst@vlnb.net> :
>
> I've recently bought Realtek RTL8169S-32 chip based Gigabit Ethernet card:
> 
> # lspci -vv
[...]
> I've noticed that all TX offload features (tx-checksumming, 
> scatter-gather and TSO) are disabled by default and should be manually 
> enabled by ethtool. I wonder, is there any particular reason for that? 

As far as I can tell, it is mostly a lack of pressure from the users and
my desire to avoid a change of behavior.

> Why they are not enabled by default as it was done for e1000 or tg3? Are 
> there any hidden drawbacks in enabling them?

None that I know of. I had not noticed a huge difference and people did
not comment a lot either...

> Those offload options are definitely work. They give in my setup (32-bit 
> 66MHz PCI, Xeon 1.7GHz CPU, open-iscsi) CPU offload from 75% to 45% and 
> data write throughput improvement from 55MB/s to 59MB/s.

...but your datapoint is welcome.

-- 
Ueimor

      reply	other threads:[~2007-10-16 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 15:23 Vladislav Bolkhovitin
2007-10-16 17:25 ` Francois Romieu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071016172517.GA8120@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vst@vlnb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®