From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934151AbXJPP1b (ORCPT ); Tue, 16 Oct 2007 11:27:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933407AbXJPP1R (ORCPT ); Tue, 16 Oct 2007 11:27:17 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:34956 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934396AbXJPP1P (ORCPT ); Tue, 16 Oct 2007 11:27:15 -0400 Date: Wed, 17 Oct 2007 01:27:06 +1000 From: Stephen Rothwell To: Joachim Fenkes Cc: Jeff Garzik , Thomas Q Klein , Jan-Bernd Themann , netdev@vger.kernel.org, Paul Mackerras , LKML , LinuxPPC-Dev , Christoph Raisch , Marcus Eder , Paul Mackerras , Stefan Roscher Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Message-Id: <20071017012706.adbd3188.sfr@canb.auug.org.au> In-Reply-To: <200710162320.00630.fenkes@de.ibm.com> References: <200710162320.00630.fenkes@de.ibm.com> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Wed__17_Oct_2007_01_27_06_+1000_0XWMKq/49uR6BW_i" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org --Signature=_Wed__17_Oct_2007_01_27_06_+1000_0XWMKq/49uR6BW_i Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 16 Oct 2007 23:20:00 +0200 Joachim Fenkes wrote: > One small change - I intend to remove the name and owner fields from struct of_platform_driver, so you should not bother initialising the name field and just initialise the name field of the embedded struct device_driver instead. This, of course, means that you don't need drv->driver.name =3D drv->name; in ibmebus_register_driver. Sorry for not picking this up earlier. --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Wed__17_Oct_2007_01_27_06_+1000_0XWMKq/49uR6BW_i Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHFNhQTgG2atn1QN8RAg8JAJwNZcBRPjzYHy6ZFr4zTdD6xzbG+wCfbyFu FwuA+pG1SWXaVdvQZKza554= =sWnd -----END PGP SIGNATURE----- --Signature=_Wed__17_Oct_2007_01_27_06_+1000_0XWMKq/49uR6BW_i--