From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate
Date: Wed, 17 Oct 2007 11:43:58 +0100 [thread overview]
Message-ID: <20071017114358.3d2b166f@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.64N.0710161857280.22596@blysk.ds.pg.gda.pl>
On Tue, 16 Oct 2007 19:12:11 +0100 (BST)
"Maciej W. Rozycki" <macro@linux-mips.org> wrote:
> The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
> a problem with the baud_table within. The comparison operators are
> reversed and as a result this table's entries never match and BOTHER is
> always used.
Oops. I thought I'd fixed that one. Bit bothersome its been in -mm that
long before anyone noticed.
ACK the first bit.
> Additionally this function's prototype is not exported unlike the
> function itself.
That bit seems out of date and a prototype was added later in -mm
next prev parent reply other threads:[~2007-10-17 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 18:12 Maciej W. Rozycki
2007-10-16 23:05 ` Roel Kluin
2007-10-23 17:32 ` Maciej W. Rozycki
2007-10-17 10:43 ` Alan Cox [this message]
2007-10-23 17:27 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017114358.3d2b166f@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®