From: Nick Piggin <npiggin@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: mikulas@artax.karlin.mff.cuni.cz, arjan@infradead.org,
linux-kernel@vger.kernel.org,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: LFENCE instruction (was: [rfc][patch 3/3] x86: optimise barriers)
Date: Wed, 17 Oct 2007 14:28:42 +0200 [thread overview]
Message-ID: <20071017122842.GB14401@wotan.suse.de> (raw)
In-Reply-To: <E1Ii1oL-0005I3-00@gondolin.me.apana.org.au>
On Wed, Oct 17, 2007 at 01:51:17PM +0800, Herbert Xu wrote:
> Nick Piggin <npiggin@suse.de> wrote:
> >
> > Also, for non-wb memory. I don't think the Intel document referenced
> > says anything about this, but the AMD document says that loads can pass
> > loads (page 8, rule b).
> >
> > This is why our rmb() is still an lfence.
>
> BTW, Xen (in particular, the code in drivers/xen) uses mb/rmb/wmb
> instead of smp_mb/smp_rmb/smp_wmb when it accesses memory that's
> shared with other Xen domains or the hypervisor.
>
> The reason this is necessary is because even if a Xen domain is
> UP the hypervisor might be SMP.
>
> It would be nice if we can have these adopt the new SMP barriers
> on x86 instead of the IO ones as they currently do.
That's a good point actually. Something like raw_smp_*mb, which
always orders memory, but only for regular WB operatoins. I could
put that on the todo list...
prev parent reply other threads:[~2007-10-17 12:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 20:47 Mikulas Patocka
2007-10-15 21:37 ` Arjan van de Ven
2007-10-15 22:08 ` Mikulas Patocka
2007-10-16 0:11 ` H. Peter Anvin
2007-10-16 10:17 ` Mikulas Patocka
2007-10-16 15:42 ` LFENCE instruction H. Peter Anvin
2007-10-16 21:25 ` Mikulas Patocka
2007-10-16 0:22 ` LFENCE instruction (was: [rfc][patch 3/3] x86: optimise barriers) Nick Piggin
2007-10-16 10:33 ` Mikulas Patocka
2007-10-16 22:29 ` Nick Piggin
2007-10-16 23:05 ` Mikulas Patocka
2007-10-16 23:21 ` Nick Piggin
2007-10-17 0:30 ` Mikulas Patocka
2007-10-17 12:24 ` Nick Piggin
2007-10-18 17:06 ` Mikulas Patocka
2007-10-17 5:51 ` Herbert Xu
2007-10-17 12:28 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017122842.GB14401@wotan.suse.de \
--to=npiggin@suse.de \
--cc=arjan@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®